Skip to content

Add Tenancy Support to VLAN Group #18296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sleepinggenius2 opened this issue Jan 3, 2025 · 0 comments
Closed

Add Tenancy Support to VLAN Group #18296

sleepinggenius2 opened this issue Jan 3, 2025 · 0 comments
Assignees
Labels
complexity: medium Requires a substantial but not unusual amount of effort to implement status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Milestone

Comments

@sleepinggenius2
Copy link
Contributor

NetBox version

v4.2-beta1

Feature type

Data model extension

Triage priority

N/A

Proposed functionality

Add the tenant field to the VLANGroup model to support tenancy. Ideally, show the tenant with an "*" appended in the Tenant column on the VLAN table for a VLAN that is not explicitly assigned to a Tenant, but inherited from its group, just like is done with the IPAddress table when its Prefix has an assigned Tenant.

Use case

The VLAN model already supports tenancy, so it's curious why the VLANGroup model does not. When using a VLANGroup to document the VLANs on an ENNI, it would be useful to also associate the group to a Tenant and not just the VLAN members under it. This would also allow for additional validation opportunities, like it could be enforced that the Tenant set on the VLAN and VLANGroup match (I think it makes sense to leave this as a custom validation opportunity). We added a custom field for this in our environment today, but that has the limitation that when you go to the details page for a Tenant, it is not listed under the related objects.

Database changes

Add nullable tenant ForeignKey to tenancy.Tenant.

External dependencies

None

@sleepinggenius2 sleepinggenius2 added status: needs triage This issue is awaiting triage by a maintainer type: feature Introduction of new functionality to the application labels Jan 3, 2025
@jeremystretch jeremystretch added needs milestone Awaiting prioritization for inclusion with a future NetBox release status: backlog Awaiting selection for work complexity: medium Requires a substantial but not unusual amount of effort to implement and removed status: needs triage This issue is awaiting triage by a maintainer labels Feb 11, 2025
@arthanson arthanson self-assigned this Feb 20, 2025
@arthanson arthanson removed the status: backlog Awaiting selection for work label Feb 20, 2025
@jeremystretch jeremystretch added this to the v4.3 milestone Feb 20, 2025
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation and removed needs milestone Awaiting prioritization for inclusion with a future NetBox release labels Feb 20, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
complexity: medium Requires a substantial but not unusual amount of effort to implement status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Projects
None yet
Development

No branches or pull requests

3 participants