Skip to content

Hangup if you try and navigate away while editing an Edge #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jdanish opened this issue Aug 5, 2020 · 2 comments
Closed

Hangup if you try and navigate away while editing an Edge #101

jdanish opened this issue Aug 5, 2020 · 2 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@jdanish
Copy link
Collaborator

jdanish commented Aug 5, 2020

Steps to reproduce:

Approach 1

  1. Create node
  2. Add edge
  3. Change mind, cancel edge entry
  4. Edge doesn't go away
  5. Hit delete
  6. Edge source/target blank now, but edge listing doesn't go away and stops other text fields from functioning.
  7. Reloading makes the blank edge go away and now text fields are behaving the way the should.

Approach 2

    • Click on a node
    • Add new edge
    • Cancel edge entry
    • Ghost edge remains in the edge list
    • ((editing is locked now, cant type in node search)
    • Click create new node
    • ((things unlock now))
    • Cancel create node
    • Ghost edge is gone now
@jdanish jdanish added the bug Something isn't working label Aug 5, 2020
@benloh
Copy link
Collaborator

benloh commented Aug 5, 2020

This is related to #96

@benloh
Copy link
Collaborator

benloh commented Aug 6, 2020

Fixed with 2577488

Canceling a new unsaved edge now properly removes the new edge component and restores the node editor state and search field state.

@benloh benloh closed this as completed Aug 6, 2020
@benloh benloh added this to the Version 1.3.0 milestone Aug 17, 2020
@benloh benloh mentioned this issue Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants