-
Notifications
You must be signed in to change notification settings - Fork 3
Edge Weight first pass for VFOI #245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Did we make a reference anywhere for what the needed files to touch were? |
See #252 for a reference that covers all the steps. |
I'm assuming that this means the maximum width of the line in a unit like pixels. |
Yes, the actual number in the edge table should not change, but the display should have a maximum width so that we don't blow out the rest of the graph. |
I am still a bit confused by this phrasing. Does "actual number in the edge table" refer to the the count of edges? or is this a link to the weight attribute being added?
|
My understanding (@kalanicraig please verify): Each edge has a weight. Right now, all edges are defaulting to 1. So if we have: A -> B weight 2 All three would be listed in the edge table. However, when drawing the line between A and B, the system would note that there is a total weight of 5. If the max is 5, it'll draw it that way. If the max is 4, it'll draw a width 4 line, but if you look at the tables or filters the weights will be as listed above. Incidentally, the display would be a bi-directional arrow in this case A <-> B. That help? Sorry to be unclear. |
That helps a lot! Thanks! I didn't realize that bidirectional edges were modeled in this way, so that was my missing bit of knowledge to make sense of it. |
Well, we are breaking some norms but I am AOK with that as it gives us flexibility. People can enforce norms on their own if they want. :). |
Ben helped me add the weight support for UI, data writing, edge table. |
Uh oh!
There was an error while loading. Please reload this page.
Add the option to include edge weight into the net.create interface.
The text was updated successfully, but these errors were encountered: