Skip to content

Typing in an Edge Source/Target node name does not enable the "Save" button #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
benloh opened this issue Jan 26, 2019 · 3 comments
Closed

Comments

@benloh
Copy link
Collaborator

benloh commented Jan 26, 2019

The Problem

The AutoComplete field is designed to support a variety of input methods, including selecting by clicking on the graph and typing a partial name, viewing suggestions, and selecting a suggestion. This generally works well when it's used in the Search field or the NodeSelector form.

When editing an edge, the AutoComplete field is also used to set the Source (and more commonly) the Target nodes. This generally works well when the user either clicks on a node on the graph to select it, or when using type-ahead to select a node -- they type a partial node name, then they click on the full name in the suggestion. This works because clicking on a suggested node triggers a SOURCE_SELECT event, where we can verify that the selected node is a valid node.

The problem occurs when the user types in the full name of the node and then hits Tab to go on to the next field. In this case, no event is triggered, so we never verify that the node name typed in is a valid node, and therefore we don't re-enable the "Save" button.

To replicate:

  1. Select a node
  2. Click "Add New Edge"
  3. Type the name of another edge and hit "tab"
  4. The "Save" button remains disabled because the system doesn't know we have selected a valid target node.
@benloh
Copy link
Collaborator Author

benloh commented Jan 26, 2019

The simple solution might be to use an unfocus event on the AutoComplete field to trigger a selection verification.

@benloh
Copy link
Collaborator Author

benloh commented Jan 26, 2019

This is fixed in Pull Request #59.

@benloh benloh closed this as completed Jan 26, 2019
@benloh benloh reopened this Jan 28, 2019
@benloh
Copy link
Collaborator Author

benloh commented Jan 29, 2019

Pull Request merged.

@benloh benloh closed this as completed Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant