Skip to content

Commit 36a5865

Browse files
committed
Only build openssl-classes and boringssl-static on windows
Motivation: When on windows we should only try to build openssl-classesand boringssl-static as nothing else is supported atm Modifications: - Add profile for windows which configure the correct modules to use - Adjust workflow for windows to depend on the new profile Result: ./mvn clean package works on windows out of the box
1 parent 62b0a1a commit 36a5865

File tree

4 files changed

+21
-3
lines changed

4 files changed

+21
-3
lines changed

.github/workflows/ci-build.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ jobs:
9898
build-windows-m2-repository-cache-
9999
100100
- name: Build netty-tcnative-boringssl-static
101-
run: ./mvnw.cmd --file pom.xml -am -pl boringssl-static clean package
101+
run: ./mvnw.cmd --file pom.xml clean package
102102

103103
- uses: actions/upload-artifact@v3
104104
if: ${{ failure() }}

.github/workflows/ci-deploy.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ jobs:
101101
stage-snapshot-windows-m2-repository-cache-
102102
103103
- name: Build netty-tcnative-boringssl-static
104-
run: ./mvnw.cmd --file pom.xml -am -pl boringssl-static clean package org.sonatype.plugins:nexus-staging-maven-plugin:deploy -DaltStagingDirectory=local-staging -DskipRemoteStaging=true -DskipTests=true
104+
run: ./mvnw.cmd --file pom.xml clean package org.sonatype.plugins:nexus-staging-maven-plugin:deploy -DaltStagingDirectory=local-staging -DskipRemoteStaging=true -DskipTests=true
105105

106106
- name: Upload local staging directory
107107
uses: actions/upload-artifact@v3

.github/workflows/ci-pr.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ jobs:
9494
build-pr-windows-m2-repository-cache-
9595
9696
- name: Build netty-tcnative-boringssl-static
97-
run: ./mvnw.cmd --file pom.xml -am -pl boringssl-static clean package
97+
run: ./mvnw.cmd --file pom.xml clean package
9898

9999
- uses: actions/upload-artifact@v3
100100
if: ${{ failure() }}

pom.xml

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -788,6 +788,24 @@
788788
</modules>
789789
</profile>
790790

791+
792+
<profile>
793+
<id>windows-compile-static-only</id>
794+
<activation>
795+
<os>
796+
<family>windows</family>
797+
</os>
798+
</activation>
799+
<properties>
800+
<moduleSelector>none</moduleSelector>
801+
</properties>
802+
<modules>
803+
<!-- Ony Windows we only support boringssl-static -->
804+
<module>openssl-classes</module>
805+
<module>boringssl-static</module>
806+
</modules>
807+
</profile>
808+
791809
<!--
792810
Profile for building all modules. This is enabled by default so if any profile is manually specified,
793811
this will be disabled automatically.

0 commit comments

Comments
 (0)