Skip to content

Refactor test resources to separate JSON Schema Test Suite files from project specific files #692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fdutton opened this issue Apr 6, 2023 · 1 comment · Fixed by #697

Comments

@fdutton
Copy link
Contributor

fdutton commented Apr 6, 2023

I propose moving the specification files from JSON Schema Test Suite to src/test/suite. This would provide the following benefits:

  • Makes merging updates from that project into this one easier as it reduces the chance of removing or overwriting this project's files
  • Makes it easier to see exactly what changed in the specification thus making it easier to see what functional changes are required to conform (e.g., content.json moved from draft2019-09/optional to draft2019-09 and draft2019-09/optional/zeroTerminatedFloats.json was removed)
  • Enables the opportunity to populate src/test/suite by linking to that project thus eliminating the need to manually merge its changes into this project (it is also possible for Maven to download and unpack a specific version of the source code)
  • Enables more complicated processing of specification files. JSON Schema Test Suite has informed validators to expect specification files to appear at the root of the tests folder. The validators are now expected to extract $schema from the specification file rather than using the folder name (e.g., tests/draft2019-09)

This change depends on #690 being accepted.

@fdutton fdutton changed the title Refactor test resources to separate those from JSON Schema Test Suite from project specific ones Refactor test resources to separate JSON Schema Test Suite files from project specific files Apr 6, 2023
@stevehu
Copy link
Contributor

stevehu commented Apr 7, 2023

@fdutton This is a fantastic idea. Maintaining the Test Suite is time-consuming as the target changes all the time. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants