Skip to content

More thorough tests for the filtering.py module #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
niksirbi opened this issue Mar 12, 2024 · 0 comments · Fixed by #209
Closed

More thorough tests for the filtering.py module #138

niksirbi opened this issue Mar 12, 2024 · 0 comments · Fixed by #209
Assignees
Labels
enhancement New optional feature

Comments

@niksirbi
Copy link
Member

Is your feature request related to a problem? Please describe.
PR #116 introduced the filtering.py module and corresponding tests test_filtering.y which reach 100% coverage. However, due to time constraints we haven't implemented tests to cover all edge cases (e.g. currently only a single example dataset is tested).

Describe the solution you'd like
Test the filtering functions against a more complete set of sample data and thoroughly validate the expected behaviour.
As an example, we could try manually introducing series of consecutive NaNs with varying lengths in an existing dataset, and check that the correct amount of NaNs are removed/interpolated over.

@niksirbi niksirbi added the enhancement New optional feature label Mar 12, 2024
@niksirbi niksirbi moved this from 🤔 Triage to 📝 Todo in movement progress tracker Mar 12, 2024
@lochhh lochhh linked a pull request Jul 11, 2024 that will close this issue
10 tasks
@github-project-automation github-project-automation bot moved this from 📝 Todo to ✅ Done in movement progress tracker Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New optional feature
Projects
Development

Successfully merging a pull request may close this issue.

2 participants