Skip to content

Commit 6e5fe02

Browse files
committed
Customized bottom sheet.
1 parent f6de7a8 commit 6e5fe02

21 files changed

+293
-68
lines changed

app/src/main/java/com/nextcloud/ui/fileactions/FileActionsBottomSheet.kt

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,9 @@ import android.view.View
1818
import android.view.ViewGroup
1919
import android.widget.Toast
2020
import androidx.annotation.IdRes
21-
import androidx.appcompat.content.res.AppCompatResources
2221
import androidx.core.os.bundleOf
2322
import androidx.core.view.isEmpty
23+
import androidx.core.content.res.ResourcesCompat
2424
import androidx.core.view.isVisible
2525
import androidx.fragment.app.FragmentManager
2626
import androidx.fragment.app.setFragmentResult
@@ -94,8 +94,6 @@ class FileActionsBottomSheet : BottomSheetDialogFragment(), Injectable {
9494
bottomSheetDialog.behavior.state = BottomSheetBehavior.STATE_EXPANDED
9595
bottomSheetDialog.behavior.skipCollapsed = true
9696

97-
viewThemeUtils.platform.colorViewBackground(binding.bottomSheet, ColorRole.SURFACE)
98-
9997
return binding.root
10098
}
10199

@@ -149,7 +147,11 @@ class FileActionsBottomSheet : BottomSheetDialogFragment(), Injectable {
149147

150148
private fun setMultipleFilesThumbnail() {
151149
context?.let {
152-
val drawable = viewThemeUtils.platform.tintDrawable(it, R.drawable.file_multiple, ColorRole.PRIMARY)
150+
// NMC Customization
151+
val drawable = viewThemeUtils.platform.colorDrawable(
152+
ResourcesCompat.getDrawable(it.resources, R.drawable.file_multiple, null)!!,
153+
it.resources.getColor(R.color.primary, null)
154+
)
153155
binding.thumbnailLayout.thumbnail.setImageDrawable(drawable)
154156
}
155157
}
@@ -282,12 +284,8 @@ class FileActionsBottomSheet : BottomSheetDialogFragment(), Injectable {
282284
}
283285
text.setText(action.title)
284286
if (action.icon != null) {
285-
val drawable =
286-
viewThemeUtils.platform.tintDrawable(
287-
requireContext(),
288-
AppCompatResources.getDrawable(requireContext(), action.icon)!!
289-
)
290-
icon.setImageDrawable(drawable)
287+
//NMC customization
288+
icon.setImageResource(action.icon)
291289
}
292290
}
293291
return itemBinding.root

app/src/main/java/com/owncloud/android/ui/dialog/SendFilesDialog.kt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ import android.view.ViewGroup
1919
import android.widget.Toast
2020
import androidx.recyclerview.widget.GridLayoutManager
2121
import com.google.android.material.bottomsheet.BottomSheetDialogFragment
22-
import com.nextcloud.android.common.ui.theme.utils.ColorRole
2322
import com.nextcloud.client.di.Injectable
2423
import com.nextcloud.client.utils.IntentUtil.createSendIntent
2524
import com.owncloud.android.R
@@ -60,7 +59,6 @@ class SendFilesDialog : BottomSheetDialogFragment(R.layout.send_files_fragment),
6059
binding = SendFilesFragmentBinding.inflate(inflater, container, false)
6160

6261
setupSendButtonRecyclerView()
63-
viewThemeUtils?.platform?.colorViewBackground(binding.bottomSheet, ColorRole.SURFACE)
6462

6563
return binding.root
6664
}

app/src/main/java/com/owncloud/android/ui/fragment/GalleryFragmentBottomSheetDialog.kt

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -42,23 +42,6 @@ class GalleryFragmentBottomSheetDialog(
4242
}
4343

4444
private fun setupLayout() {
45-
viewThemeUtils.platform.colorViewBackground(binding.bottomSheet, ColorRole.SURFACE)
46-
47-
listOf(
48-
binding.tickMarkShowImages,
49-
binding.tickMarkShowVideos
50-
).forEach {
51-
viewThemeUtils.platform.colorImageView(it, ColorRole.PRIMARY)
52-
}
53-
54-
listOf(
55-
binding.btnSelectMediaFolder,
56-
binding.btnHideVideos,
57-
binding.btnHideImages
58-
).forEach {
59-
viewThemeUtils.material.colorMaterialButtonText(it)
60-
}
61-
6245
when (currentMediaState) {
6346
MediaState.MEDIA_STATE_PHOTOS_ONLY -> {
6447
binding.tickMarkShowImages.visibility = View.VISIBLE

app/src/main/java/com/owncloud/android/ui/fragment/OCFileListBottomSheetDialog.java

Lines changed: 13 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111

1212
import com.google.android.material.bottomsheet.BottomSheetDialog;
1313
import com.google.gson.Gson;
14-
import com.nextcloud.android.common.ui.theme.utils.ColorRole;
1514
import com.nextcloud.client.account.User;
1615
import com.nextcloud.client.device.DeviceInfo;
1716
import com.nextcloud.client.di.Injectable;
@@ -76,12 +75,8 @@ protected void onCreate(Bundle savedInstanceState) {
7675
binding = FileListActionsBottomSheetFragmentBinding.inflate(getLayoutInflater());
7776
setContentView(binding.getRoot());
7877

79-
viewThemeUtils.platform.colorImageView(binding.menuIconUploadFiles, ColorRole.PRIMARY);
80-
viewThemeUtils.platform.colorImageView(binding.menuIconUploadFromApp, ColorRole.PRIMARY);
81-
viewThemeUtils.platform.colorImageView(binding.menuIconDirectCameraUpload, ColorRole.PRIMARY);
82-
viewThemeUtils.platform.colorImageView(binding.menuIconScanDocUpload, ColorRole.PRIMARY);
83-
viewThemeUtils.platform.colorImageView(binding.menuIconMkdir, ColorRole.PRIMARY);
84-
viewThemeUtils.platform.colorImageView(binding.menuIconAddFolderInfo, ColorRole.PRIMARY);
78+
// NMC Customization
79+
reorderUploadFromOtherAppsView();
8580

8681
binding.addToCloud.setText(getContext().getResources().getString(R.string.add_to_cloud,
8782
themeUtils.getDefaultDisplayNameForRootFolder(getContext())));
@@ -136,8 +131,9 @@ protected void onCreate(Bundle savedInstanceState) {
136131
binding.menuDirectCameraUpload.setVisibility(View.GONE);
137132
}
138133

134+
// not required for NMC
139135
// create rich workspace
140-
if (editorUtils.isEditorAvailable(user,
136+
/* if (editorUtils.isEditorAvailable(user,
141137
MimeTypeUtil.MIMETYPE_TEXT_MARKDOWN) &&
142138
file != null && !file.isEncrypted()) {
143139
// richWorkspace
@@ -154,11 +150,19 @@ protected void onCreate(Bundle savedInstanceState) {
154150
} else {
155151
binding.menuCreateRichWorkspace.setVisibility(View.GONE);
156152
binding.menuCreateRichWorkspaceDivider.setVisibility(View.GONE);
157-
}
153+
} */
158154

159155
setupClickListener();
160156
}
161157

158+
private void reorderUploadFromOtherAppsView() {
159+
// move the upload from other app option
160+
// below Create new folder or Create new e2ee folder
161+
// NMC-3095 requirement
162+
binding.actionLinear.removeView(binding.menuUploadFromApp);
163+
binding.actionLinear.addView(binding.menuUploadFromApp, binding.actionLinear.indexOfChild(binding.menuEncryptedMkdir) + 1);
164+
}
165+
162166
private void setupClickListener() {
163167
binding.menuCreateRichWorkspace.setOnClickListener(v -> {
164168
actions.createRichWorkspace();
Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
<vector xmlns:android="http://schemas.android.com/apk/res/android"
2+
android:width="24dp"
3+
android:height="24dp"
4+
android:viewportWidth="24"
5+
android:viewportHeight="24">
6+
<path
7+
android:pathData="M4,21.75a3,3 0,0 1,-3 -3L1,2.25L7.5,2.25a3.65,3.65 0,0 1,2.7 1.2l0.45,0.45a1.43,1.43 0,0 0,0.85 0.35L23,4.25v14.5a3,3 0,0 1,-3 3ZM2.5,18.75a1.46,1.46 0,0 0,1.43 1.5L20,20.25a1.47,1.47 0,0 0,1.5 -1.44L21.5,5.75h-10A2.57,2.57 0,0 1,9.6 4.9l-0.45,-0.45a2.38,2.38 0,0 0,-1.65 -0.7h-5Z"
8+
android:fillColor="#262626"/>
9+
<path
10+
android:pathData="M14.14,16.56L9.86,16.56a1.07,1.07 0,0 1,-1.07 -1.08L8.79,12.09h0.89v-0.71a2.32,2.32 0,0 1,4.64 0v0.71h0.89v3.39A1.07,1.07 0,0 1,14.14 16.56ZM12,13.56a0.54,0.54 0,0 0,-0.54 0.53,0.55 0.55,0 0,0 0.18,0.4v0.68h0.72v-0.68a0.53,0.53 0,0 0,0 -0.75A0.52,0.52 0,0 0,12 13.52ZM12,9.63a1.79,1.79 0,0 0,-1.79 1.79v0.71h3.58v-0.71A1.79,1.79 0,0 0,12 9.59Z"
11+
android:fillColor="#262626"/>
12+
</vector>
Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
<vector xmlns:android="http://schemas.android.com/apk/res/android"
2+
android:width="24dp"
3+
android:height="24dp"
4+
android:viewportWidth="24"
5+
android:viewportHeight="24">
6+
<path
7+
android:pathData="M17.75,0.5L8,0.5L8,3.5L5,3.5L5,6.5L2,6.5L2,21.25C2,22.4925 3.0075,23.5 4.25,23.5L13.25,23.5C14.4925,23.5 15.5,22.4925 15.5,21.25L15.5,20.5L16.25,20.5C17.4925,20.5 18.5,19.4925 18.5,18.25L18.5,17.5L19.25,17.5C20.4925,17.5 21.5,16.4925 21.5,15.25L21.5,4.3635L17.75,0.5ZM14,21.25C14,21.6635 13.6635,22 13.25,22L4.25,22C3.8365,22 3.5,21.6635 3.5,21.25L3.5,8L5,8L5,18.25C5,19.4925 6.0075,20.5 7.25,20.5L14,20.5L14,21.25ZM17,18.25C17,18.6635 16.6635,19 16.25,19L7.25,19C6.8365,19 6.5,18.6635 6.5,18.25L6.5,5L8,5L8,15.25C8,16.4925 9.0075,17.5 10.25,17.5L17,17.5L17,18.25ZM19.25,16L10.25,16C9.8365,16 9.5,15.6635 9.5,15.25L9.5,2L16,2L16,4.1705C16,4.9045 16.595,5.5 17.3295,5.5L20,5.5L20,15.25C20,15.6635 19.6635,16 19.25,16Z"
8+
android:strokeWidth="1"
9+
android:fillColor="#262626"
10+
android:fillType="nonZero"
11+
android:strokeColor="#00000000"/>
12+
</vector>
Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
<vector xmlns:android="http://schemas.android.com/apk/res/android"
2+
android:width="24dp"
3+
android:height="24dp"
4+
android:viewportWidth="24"
5+
android:viewportHeight="24">
6+
<path
7+
android:pathData="M2.5,1L2.5,20C2.5,21.65 3.85,23 5.5,23L15.5,23L20.5,18L20.5,1L2.5,1ZM4,20L4,2.5L19,2.5L19,17L16,17C15.15,17 14.5,17.65 14.5,18.5L14.5,21.5L5.5,21.5C4.65,21.5 4,20.85 4,20Z"
8+
android:strokeWidth="1"
9+
android:fillColor="#262626"
10+
android:fillType="evenOdd"
11+
android:strokeColor="#00000000"/>
12+
</vector>

app/src/main/res/layout/file_actions_bottom_sheet.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
style="@style/Widget.Material3.BottomSheet"
1414
android:layout_width="match_parent"
1515
android:layout_height="wrap_content"
16+
android:background="@color/bottom_sheet_bg_color"
1617
android:layout_gravity="bottom"
1718
app:layout_behavior="com.google.android.material.bottomsheet.BottomSheetBehavior">
1819

@@ -59,6 +60,7 @@
5960
android:ellipsize="middle"
6061
android:lines="1"
6162
android:textAppearance="@style/TextAppearance.Material3.HeadlineSmall"
63+
android:textColor="@color/bottom_sheet_txt_color"
6264
tools:text="Test file name which is very very very very very long.pdf" />
6365

6466
</LinearLayout>

app/src/main/res/layout/file_actions_bottom_sheet_item.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
android:layout_width="@dimen/iconized_single_line_item_icon_size"
3030
android:layout_height="@dimen/iconized_single_line_item_icon_size"
3131
android:contentDescription="@null"
32-
app:tint="@color/primary"
32+
app:tint="@color/bottom_sheet_icon_color"
3333
tools:src="@drawable/ic_delete" />
3434

3535
<LinearLayout
@@ -44,7 +44,7 @@
4444
android:layout_height="wrap_content"
4545
android:layout_gravity="center_vertical"
4646
android:layout_marginStart="@dimen/bottom_sheet_text_start_margin"
47-
android:textColor="@color/text_color"
47+
android:textColor="@color/bottom_sheet_txt_color"
4848
android:textSize="@dimen/bottom_sheet_text_size"
4949
tools:text="Delete file" />
5050

app/src/main/res/layout/file_list_actions_bottom_sheet_creator.xml

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,15 @@
88
-->
99
<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
1010
xmlns:tools="http://schemas.android.com/tools"
11+
xmlns:app="http://schemas.android.com/apk/res-auto"
1112
android:id="@+id/creator_container"
1213
android:layout_width="match_parent"
1314
android:layout_height="@dimen/bottom_sheet_item_height"
1415
android:background="?android:attr/selectableItemBackground"
1516
android:gravity="center_vertical"
1617
android:orientation="horizontal"
18+
android:paddingTop="@dimen/standard_half_padding"
19+
android:paddingBottom="@dimen/standard_half_padding"
1720
android:paddingLeft="@dimen/standard_padding"
1821
android:paddingRight="@dimen/standard_padding"
1922
tools:ignore="UseCompoundDrawables">
@@ -22,8 +25,7 @@
2225
android:id="@+id/creator_thumbnail"
2326
android:layout_width="24dp"
2427
android:layout_height="24dp"
25-
android:layout_marginTop="@dimen/standard_margin"
26-
android:layout_marginBottom="@dimen/standard_margin"
28+
app:tint="@color/bottom_sheet_icon_color"
2729
android:contentDescription="@null"
2830
android:src="@drawable/file_ppt" />
2931

@@ -32,8 +34,8 @@
3234
android:layout_width="wrap_content"
3335
android:layout_height="wrap_content"
3436
android:layout_gravity="center_vertical"
35-
android:layout_marginStart="@dimen/bottom_sheet_text_start_margin"
37+
android:layout_marginStart="@dimen/standard_margin"
3638
android:text="@string/create_new_presentation"
37-
android:textColor="@color/text_color"
39+
android:textColor="@color/bottom_sheet_txt_color"
3840
android:textSize="@dimen/bottom_sheet_text_size" />
3941
</LinearLayout>

0 commit comments

Comments
 (0)