dev: Fix new errors from pyright >1.1.218, <1.1.225

Disabling strictParameterNoneValue restores the previous default
behaviour prior to 1.1.224.

Related inference improvement appears to be that boto_client in a few
places could actually be None (meaning calling a method on it would
error), so just remove the unnecessary and unused keyword argument
causing that.

Author: tsibley

nextstrain/cli/aws/cognito/srp.py

@@ -245,8 +245,8 @@ def process_challenge(self, challenge_parameters):
             )
         return response
 
-    def authenticate_user(self, client=None):
-        boto_client = self.client or client
+    def authenticate_user(self):
+        boto_client = self.client
         auth_params = self.get_auth_params()
         response = boto_client.initiate_auth(
             AuthFlow="USER_SRP_AUTH",
@@ -272,8 +272,8 @@ def authenticate_user(self, client=None):
             "The %s challenge is not supported" % response["ChallengeName"]
         )
 
-    def set_new_password_challenge(self, new_password, client=None):
-        boto_client = self.client or client
+    def set_new_password_challenge(self, new_password):
+        boto_client = self.client
         auth_params = self.get_auth_params()
         response = boto_client.initiate_auth(
             AuthFlow="USER_SRP_AUTH",

nextstrain/cli/runner/aws_batch/__init__.py

@@ -87,6 +87,13 @@ def register_arguments(parser) -> None:
 
 
 def run(opts, argv, working_volume = None, extra_env = {}, cpus: int = None, memory: int = None) -> int:
+    # Unlike other runners, the AWS Bach runner currently *requires* a working
+    # dir.  This is ok as we only provide the AWS Batch runner for commands
+    # which also require a working dir (e.g. build), whereas other runners also
+    # work with commands that don't.
+    #   -trs, 28 Feb 2022
+    assert working_volume is not None
+
     local_workdir = resolve_path(working_volume.src)
 
     if opts.attach:

pyrightconfig.json

@@ -19,5 +19,6 @@
   "reportSelfClsParameterName": true,
   "reportInvalidStubStatement": true,
   "reportIncompleteStub": true,
-  "reportUnsupportedDunderAll": true
+  "reportUnsupportedDunderAll": true,
+  "strictParameterNoneValue": false
 }