Skip to content

Commit 2398f98

Browse files
authored
Merge pull request #284 from nf-core/fix-time-limits
Fix time limits
2 parents f97a466 + bc8825a commit 2398f98

File tree

3 files changed

+17
-10
lines changed

3 files changed

+17
-10
lines changed

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
77

88
- Update template to v2.11.1 ([#279](https://github.com/nf-core/scrnaseq/pull/279))
99
- Add support for paired GEX+ATAC sequencing using cellranger-arc ([#274](https://github.com/nf-core/scrnaseq/pull/274))
10-
- Increase default runtime limits for all processes ([#281])(https://github.com/nf-core/scrnaseq/pull/281)
10+
- Increase default runtime limits for some processes ([#281](https://github.com/nf-core/scrnaseq/pull/281), [#284](https://github.com/nf-core/scrnaseq/pull/284))
1111
- Better support for custom protocols ([#273](https://github.com/nf-core/scrnaseq/pull/273)).
1212
- The universc protocol is now specified via the `--protocol` flag
1313
- Any protocol specified is now passed to the respective aligner

conf/base.config

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -27,25 +27,25 @@ process {
2727
withLabel:process_single {
2828
cpus = { check_max( 1 , 'cpus' ) }
2929
memory = { check_max( 6.GB * task.attempt, 'memory' ) }
30-
time = { check_max( 8.h * task.attempt, 'time' ) }
30+
time = { check_max( 4.h * task.attempt, 'time' ) }
3131
}
3232
withLabel:process_low {
3333
cpus = { check_max( 2 * task.attempt, 'cpus' ) }
3434
memory = { check_max( 12.GB * task.attempt, 'memory' ) }
35-
time = { check_max( 8.h * task.attempt, 'time' ) }
35+
time = { check_max( 4.h * task.attempt, 'time' ) }
3636
}
3737
withLabel:process_medium {
3838
cpus = { check_max( 6 * task.attempt, 'cpus' ) }
3939
memory = { check_max( 36.GB * task.attempt, 'memory' ) }
40-
time = { check_max( 120.h * task.attempt, 'time' ) }
40+
time = { check_max( 8.h * task.attempt, 'time' ) }
4141
}
4242
withLabel:process_high {
4343
cpus = { check_max( 12 * task.attempt, 'cpus' ) }
4444
memory = { check_max( 72.GB * task.attempt, 'memory' ) }
45-
time = { check_max( 240.h * task.attempt, 'time' ) }
45+
time = { check_max( 16.h * task.attempt, 'time' ) }
4646
}
4747
withLabel:process_long {
48-
time = { check_max( 240.h * task.attempt, 'time' ) }
48+
time = { check_max( 20.h * task.attempt, 'time' ) }
4949
}
5050
withLabel:process_high_memory {
5151
memory = { check_max( 200.GB * task.attempt, 'memory' ) }
@@ -60,8 +60,4 @@ process {
6060
withName:CUSTOM_DUMPSOFTWAREVERSIONS {
6161
cache = false
6262
}
63-
//Fix for issue 196
64-
withName: 'NFCORE_SCRNASEQ:SCRNASEQ:SCRNASEQ_ALEVIN:ALEVINQC' {
65-
time = '20.h'
66-
}
6763
}

conf/modules.config

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,10 @@ process {
1717
saveAs: { filename -> filename.equals('versions.yml') ? null : filename }
1818
]
1919

20+
withName: FASTQC {
21+
time = { check_max( 120.h * task.attempt, 'time' ) }
22+
}
23+
2024
withName: SAMPLESHEET_CHECK {
2125
publishDir = [
2226
path: { "${params.outdir}/pipeline_info" },
@@ -79,6 +83,7 @@ if(params.aligner == "cellranger") {
7983
mode: params.publish_dir_mode
8084
]
8185
ext.args = {"--chemistry ${meta.chemistry} " + (meta.expected_cells ? "--expect-cells ${meta.expected_cells}" : '')}
86+
time = { check_max( 240.h * task.attempt, 'time' ) }
8287
}
8388
}
8489
}
@@ -105,6 +110,7 @@ if(params.aligner == "cellrangerarc") {
105110
mode: params.publish_dir_mode
106111
]
107112
ext.args = {meta.expected_cells ? "--expect-cells ${meta.expected_cells}" : ''}
113+
time = { check_max( 240.h * task.attempt, 'time' ) }
108114
}
109115
}
110116
}
@@ -134,6 +140,7 @@ if(params.aligner == "universc") {
134140
path: "${params.outdir}/universc",
135141
mode: params.publish_dir_mode
136142
]
143+
time = { check_max( 240.h * task.attempt, 'time' ) }
137144
}
138145
}
139146
}
@@ -159,6 +166,10 @@ if (params.aligner == "alevin") {
159166
]
160167
ext.args = "-r cr-like"
161168
}
169+
//Fix for issue 196
170+
withName: 'ALEVINQC' {
171+
time = '120.h'
172+
}
162173
}
163174
}
164175

0 commit comments

Comments
 (0)