NH4043 - Add complete keyword list to Sybase

Also set sensible defaults for string types, so at least half the
unit tests now pass.

Author: ngbrown

src/NHibernate.Test/Tools/hbm2ddl/SchemaMetadataUpdaterTest/SchemaMetadataUpdaterFixture.cs

@@ -26,8 +26,8 @@ public void CanRetrieveReservedWords()
 				var metaData = dialect.GetDataBaseSchema(connectionHelper.Connection);
 				var reserved = metaData.GetReservedWords();
 				Assert.That(reserved, Is.Not.Empty);
-				Assert.That(reserved, Has.Member("SELECT"));
-				Assert.That(reserved, Has.Member("FROM"));
+				Assert.That(reserved, Has.Member("SELECT").IgnoreCase);
+				Assert.That(reserved, Has.Member("FROM").IgnoreCase);
 			}
 			finally
 			{

src/NHibernate/Dialect/SybaseSQLAnywhere10Dialect.cs

@@ -63,17 +63,17 @@ public SybaseSQLAnywhere10Dialect()
 
 		protected virtual void RegisterCharacterTypeMappings()
 		{
-			RegisterColumnType(DbType.AnsiStringFixedLength, "CHAR(1)");
+			RegisterColumnType(DbType.AnsiStringFixedLength, "CHAR(255)");
 			RegisterColumnType(DbType.AnsiStringFixedLength, 32767, "CHAR($l)");
-			RegisterColumnType(DbType.AnsiString, "VARCHAR(1)");
+			RegisterColumnType(DbType.AnsiString, "VARCHAR(255)");
 			RegisterColumnType(DbType.AnsiString, 32767, "VARCHAR($l)");
 			RegisterColumnType(DbType.AnsiString, 2147483647, "LONG VARCHAR");
-			RegisterColumnType(DbType.StringFixedLength, "NCHAR(1)");
+			RegisterColumnType(DbType.StringFixedLength, "NCHAR(255)");
 			RegisterColumnType(DbType.StringFixedLength, 32767, "NCHAR($l)");
-			RegisterColumnType(DbType.String, "NVARCHAR(1)");
+			RegisterColumnType(DbType.String, "NVARCHAR(255)");
 			RegisterColumnType(DbType.String, 32767, "NVARCHAR($l)");
 			RegisterColumnType(DbType.String, 2147483647, "LONG NVARCHAR");
-			RegisterColumnType(DbType.Binary, "BINARY(1)");
+			RegisterColumnType(DbType.Binary, "BINARY(8000)");
 			RegisterColumnType(DbType.Binary, 32767, "VARBINARY($l)");
 			RegisterColumnType(DbType.Binary, 2147483647, "LONG BINARY");
 			RegisterColumnType(DbType.Guid, "UNIQUEIDENTIFIER");
@@ -344,8 +344,124 @@ protected virtual void RegisterMiscellaneousFunctions()
 			RegisterFunction("watcomsql", new StandardSQLFunction("watcomsql", NHibernateUtil.String));
 		}
 
+		#region private static readonly string[] DialectKeywords = { ... }
+
+		private static readonly string[] DialectKeywords =
+		{
+			"aes_decrypt",
+			"asc",
+			"attach",
+			"backup",
+			"bit",
+			"bottom",
+			"break",
+			"capability",
+			"cascade",
+			"char_convert",
+			"checkpoint",
+			"clear",
+			"comment",
+			"compressed",
+			"conflict",
+			"convert",
+			"dbspace",
+			"deleting",
+			"desc",
+			"detach",
+			"elseif",
+			"encrypted",
+			"endif",
+			"exception",
+			"existing",
+			"externlogin",
+			"force",
+			"forward",
+			"goto",
+			"holdlock",
+			"identified",
+			"index",
+			"inserting",
+			"install",
+			"instead",
+			"integrated",
+			"iq",
+			"isolation",
+			"json",
+			"kerberos",
+			"key",
+			"lock",
+			"login",
+			"long",
+			"membership",
+			"message",
+			"mode",
+			"modify",
+			"noholdlock",
+			"notify",
+			"nvarchar",
+			"off",
+			"openstring",
+			"openxml",
+			"option",
+			"options",
+			"others",
+			"passthrough",
+			"print",
+			"privileges",
+			"proc",
+			"publication",
+			"raiserror",
+			"readtext",
+			"reference",
+			"refresh",
+			"remote",
+			"remove",
+			"rename",
+			"reorganize",
+			"resource",
+			"restore",
+			"restrict",
+			"rowtype",
+			"save",
+			"session",
+			"setuser",
+			"share",
+			"spatial",
+			"sqlcode",
+			"stop",
+			"subtrans",
+			"subtransaction",
+			"synchronize",
+			"temporary",
+			"timeline",
+			"tinyint",
+			"truncate",
+			"tsequal",
+			"unbounded",
+			"uniqueidentifier",
+			"unsigned",
+			"updating",
+			"validate",
+			"varbinary",
+			"varbit",
+			"variable",
+			"varray",
+			"view",
+			"wait",
+			"waitfor",
+			"work",
+			"writetext",
+			"xml",
+		};
+
+		#endregion
+
 		protected virtual void RegisterKeywords()
 		{
+			// Register driver returned keywords for SQL Anywhere 16
+			RegisterKeywords(DialectKeywords);
+
+			// Keywords originally registered for SQL Anywhere 10 (none are in the above list)
 			RegisterKeyword("top");
 			RegisterKeyword("first");
 			RegisterKeyword("fetch");