clean up

Author: bahusoid

src/NHibernate/Loader/BatchFetchStyle.cs

@@ -1,5 +1,8 @@
 namespace NHibernate.Loader
 {
+	/// <summary>
+	/// Defines the style that should be used to perform batch loading.
+	/// </summary>
 	public enum BatchFetchStyle
 	{
 		/// <summary>

src/NHibernate/Loader/Collection/DynamicBatchingCollectionLoader.cs

@@ -30,7 +30,7 @@ private JoinWalker BuildJoinWalker(IQueryableCollection collectionPersister, ISe
 		private protected override SqlString TransformSql(SqlString sqlString, QueryParameters queryParameters, HashSet<IParameterSpecification> parameterSpecifications)
 		{
 			var columns = StringHelper.Qualify(_alias, CollectionPersister.KeyColumnNames);
-			DynamicBatchingHelper.ExpandBatchIdPlaceholder(sqlString, queryParameters, columns, Factory.Dialect, out var parameters, out var result);
+			DynamicBatchingHelper.ExpandBatchIdPlaceholder(sqlString, queryParameters, columns, Factory.Dialect, out var result, out var parameters);
 			parameterSpecifications.UnionWith(CreateParameterSpecificationsAndAssignBackTrack(parameters));
 			return result;
 		}

src/NHibernate/Loader/DynamicBatchingHelper.cs

@@ -14,7 +14,7 @@ public static SqlStringBuilder BuildBatchFetchRestrictionFragment()
 			return new SqlStringBuilder(1).Add(BatchIdPlaceholder);
 		}
 
-		public static void ExpandBatchIdPlaceholder(SqlString sqlString, QueryParameters queryParameters, string[] columns, Dialect.Dialect dialect, out Parameter[] parameters, out SqlString result)
+		public static void ExpandBatchIdPlaceholder(SqlString sqlString, QueryParameters queryParameters, string[] columns, Dialect.Dialect dialect, out SqlString result, out Parameter[] parameters)
 		{
 			var wherePart = GenerateWherePart(queryParameters, columns, dialect, out parameters);
 			result = sqlString.ReplaceLast(BatchIdPlaceholder, wherePart);

src/NHibernate/Loader/Entity/AbstractEntityLoader.cs

@@ -92,7 +92,7 @@ internal protected List<IParameterSpecification> CreateParameterSpecificationsAn
 			return specifications;
 		}
 
-		protected  override IEnumerable<IParameterSpecification> GetParameterSpecifications()
+		protected override IEnumerable<IParameterSpecification> GetParameterSpecifications()
 		{
 			return parametersSpecifications ?? (parametersSpecifications = CreateParameterSpecificationsAndAssignBackTrack(SqlString.GetParameters()).ToArray());
 		}

src/NHibernate/Loader/Entity/DynamicBatchingEntityLoaderBuilder.cs

@@ -5,10 +5,10 @@
 namespace NHibernate.Loader.Entity
 {
 	/// <summary>
-	/// A BatchingEntityLoaderBuilder that builds IUniqueEntityLoader instances capable of dynamically building
+	/// Builds <see cref="IUniqueEntityLoader"/> instances capable of dynamically building
 	/// its batch-fetch SQL based on the actual number of entity ids waiting to be fetched.
 	/// </summary>
-	public partial class DynamicBatchingEntityLoaderBuilder : BatchingEntityLoaderBuilder
+	public class DynamicBatchingEntityLoaderBuilder : BatchingEntityLoaderBuilder
 	{
 		protected override IUniqueEntityLoader BuildBatchingLoader(IOuterJoinLoadable persister, int batchSize, LockMode lockMode, ISessionFactoryImplementor factory, IDictionary<string, IFilter> enabledFilters)
 		{

src/NHibernate/Loader/Entity/DynamicEntityLoader.cs

@@ -31,14 +31,14 @@ public virtual IList DoEntityBatchFetch(ISessionImplementor session, QueryParame
 		private protected override SqlString TransformSql(SqlString sqlString, QueryParameters queryParameters, HashSet<IParameterSpecification> parameterSpecifications)
 		{
 			var columns = StringHelper.Qualify(_alias, persister.KeyColumnNames);
-			DynamicBatchingHelper.ExpandBatchIdPlaceholder(sqlString, queryParameters, columns, Factory.Dialect, out var parameters, out var result);
+			DynamicBatchingHelper.ExpandBatchIdPlaceholder(sqlString, queryParameters, columns, Factory.Dialect, out var result, out var parameters);
 			parameterSpecifications.UnionWith(CreateParameterSpecificationsAndAssignBackTrack(parameters));
 			return result;
 		}
 
 		class DynamicEntityJoinWalker : EntityJoinWalker
 		{
-			public DynamicEntityJoinWalker(IOuterJoinLoadable persister, string[] identifierColumnNames, LockMode lockMode, ISessionFactoryImplementor factory, IDictionary<string, IFilter> enabledFilters) : base(persister, identifierColumnNames, -1, lockMode, factory, enabledFilters)
+			public DynamicEntityJoinWalker(IOuterJoinLoadable persister, string[] identifierColumnNames, LockMode lockMode, ISessionFactoryImplementor factory, IDictionary<string, IFilter> enabledFilters) : base(persister, identifierColumnNames, 1, lockMode, factory, enabledFilters)
 			{
 			}
 

src/NHibernate/Loader/Entity/LegacyBatchingEntityLoaderBuilder.cs

@@ -4,6 +4,9 @@
 
 namespace NHibernate.Loader.Entity
 {
+	/// <summary>
+	/// Default batching builder. See <see cref="BatchFetchStyle.Legacy"/>
+	/// </summary>
 	public class LegacyBatchingEntityLoaderBuilder : BatchingEntityLoaderBuilder
 	{
 		protected override IUniqueEntityLoader BuildBatchingLoader(IOuterJoinLoadable persister, int batchSize, LockMode lockMode, ISessionFactoryImplementor factory, IDictionary<string, IFilter> enabledFilters)