NH-3915 - Implement bitwise not (~) in Linq Provider

Author: hazzik

src/NHibernate.Test/Linq/SelectionTests.cs

@@ -457,6 +457,15 @@ public void CanSelectConditionalObject()
 			Assert.That(fatherIsKnown, Has.Exactly(1).With.Property("FatherIsKnown").True);
 		}
 
+		[Test]
+		public void CanSelectBitwiseNot()
+		{
+			//NH-3915
+			var queryable = db.Animals.Select(a => ~a.Id);
+
+			Assert.That(queryable.ToList(), Is.EqualTo(db.Animals.ToList().Select(a => ~a.Id).ToList()));
+		}
+
 		public class Wrapper<T>
 		{
 			public T item;

src/NHibernate/Hql/Ast/HqlTreeBuilder.cs

@@ -276,11 +276,17 @@ public HqlCast Cast(HqlExpression expression, System.Type type)
 			return new HqlCast(_factory, expression, type);
 		}
 
+		[Obsolete]
 		public HqlBitwiseNot BitwiseNot()
 		{
 			return new HqlBitwiseNot(_factory);
 		}
 
+		public HqlBitwiseNot BitwiseNot(HqlExpression operand)
+		{
+			return new HqlBitwiseNot(_factory, operand);
+		}
+
 		public HqlBooleanNot BooleanNot(HqlBooleanExpression operand)
 		{
 			return new HqlBooleanNot(_factory, operand);
@@ -376,7 +382,12 @@ public HqlMethodCall MethodCall(string methodName, params HqlExpression[] parame
 			return new HqlMethodCall(_factory, methodName, parameters);
 		}
 
-		public HqlBooleanMethodCall BooleanMethodCall(string methodName, IEnumerable<HqlExpression> parameters)
+		public HqlBooleanMethodCall BooleanMethodCall(string methodName, params HqlExpression[] parameters)
+		{
+			return new HqlBooleanMethodCall(_factory, methodName, parameters);
+		}
+
+        public HqlBooleanMethodCall BooleanMethodCall(string methodName, IEnumerable<HqlExpression> parameters)
 		{
 			return new HqlBooleanMethodCall(_factory, methodName, parameters);
 		}

src/NHibernate/Hql/Ast/HqlTreeNode.cs

@@ -696,7 +696,12 @@ public HqlAverage(IASTFactory factory, HqlExpression expression)
 
 	public class HqlBitwiseNot : HqlExpression
 	{
-		public HqlBitwiseNot(IASTFactory factory) : base(HqlSqlWalker.BNOT, "not", factory)
+		public HqlBitwiseNot(IASTFactory factory) 
+			: base(HqlSqlWalker.BNOT, "not", factory)
+		{
+		}
+		public HqlBitwiseNot(IASTFactory factory, HqlExpression operand) 
+			: base(HqlSqlWalker.BNOT, "not", factory, operand)
 		{
 		}
 	}

src/NHibernate/Linq/Visitors/HqlGeneratorExpressionTreeVisitor.cs

@@ -393,7 +393,9 @@ protected HqlTreeNode VisitUnaryExpression(UnaryExpression expression)
 			switch (expression.NodeType)
 			{
 				case ExpressionType.Not:
-					return _hqlTreeBuilder.BooleanNot(VisitExpression(expression.Operand).ToBooleanExpression());
+					if (expression.Type == typeof(bool))
+						return _hqlTreeBuilder.BooleanNot(VisitExpression(expression.Operand).ToBooleanExpression());
+					return _hqlTreeBuilder.BitwiseNot(VisitExpression(expression.Operand).AsExpression());
 				case ExpressionType.Convert:
 				case ExpressionType.ConvertChecked:
 				case ExpressionType.TypeAs: