Skip to content

Commit f74eab0

Browse files
committed
Convert NHibernate.DomainModel to .NET Core multi-target project
1 parent 7acd9dd commit f74eab0

File tree

8 files changed

+96
-278
lines changed

8 files changed

+96
-278
lines changed
Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
#if !FEATURE_SERIALIZATION && NETSTANDARD
2+
// ReSharper disable once CheckNamespace
3+
namespace System
4+
{
5+
[AttributeUsage(AttributeTargets.Field, Inherited = false)]
6+
internal sealed class NonSerializedAttribute : Attribute
7+
{
8+
}
9+
}
10+
#endif
Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
#if !FEATURE_SERIALIZATION && NETSTANDARD
2+
// ReSharper disable once CheckNamespace
3+
namespace System
4+
{
5+
[AttributeUsage(AttributeTargets.Class | AttributeTargets.Struct | AttributeTargets.Enum | AttributeTargets.Delegate, Inherited = false)]
6+
internal sealed class SerializableAttribute : Attribute
7+
{
8+
}
9+
}
10+
#endif

src/NHibernate.DomainModel/Foo.cs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -368,7 +368,11 @@ public LifecycleVeto OnSave(ISession s)
368368
_component.Glarch = new Glarch();
369369
_dependent = new Fee();
370370
_dependent.Fi = "belongs to foo # " + Key;
371+
#if !NETSTANDARD
371372
_locale = Thread.CurrentThread.CurrentCulture;
373+
#else
374+
_locale = CultureInfo.CurrentCulture;
375+
#endif
372376
return LifecycleVeto.NoVeto;
373377
}
374378

src/NHibernate.DomainModel/Master.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,9 @@ public ISet<Detail> Details
4545
get { return _details; }
4646
set
4747
{
48+
#if !NETSTANDARD
4849
Trace.WriteLine("Details assigned");
50+
#endif
4951
_details = value;
5052
}
5153
}

src/NHibernate.DomainModel/NHSpecific/NullableInt32.cs

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,10 @@ namespace NHibernate.DomainModel.NHSpecific
66
/// <summary>
77
/// A nullable type that wraps an <see cref="Int32"/> value.
88
/// </summary>
9-
[TypeConverter(typeof(NullableInt32Converter)), Serializable()]
9+
#if !NETSTANDARD
10+
[TypeConverter(typeof(NullableInt32Converter))]
11+
#endif
12+
[Serializable]
1013
public struct NullableInt32 : IFormattable, IComparable
1114
{
1215
public static readonly NullableInt32 Default = new NullableInt32();

src/NHibernate.DomainModel/NHSpecific/NullableInt32Converter.cs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
#if !NETSTANDARD
12
using System;
23
using System.Collections;
34
using System.ComponentModel;
@@ -96,4 +97,5 @@ public override bool GetPropertiesSupported(ITypeDescriptorContext context)
9697
return true;
9798
}
9899
}
99-
}
100+
}
101+
#endif

src/NHibernate.DomainModel/NHibernate.DomainModel.csproj

Lines changed: 55 additions & 268 deletions
Large diffs are not rendered by default.

src/NHibernate/NHibernate.csproj

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,14 @@
1515
<GenerateAssemblyCopyrightAttribute>false</GenerateAssemblyCopyrightAttribute>
1616
</PropertyGroup>
1717

18+
<PropertyGroup Condition=" '$(TargetFramework)' == 'netstandard1.6' ">
19+
<DefineConstants>$(DefineConstants);NETSTANDARD;FEATURE_DATA_GETCOLUMNSCHEMA;FEATURE_INTERNALIZE_IESI;FEATURE_NETCORE_ICLONEABLE_API;FEATURE_NETCORE_REFLECTION_API</DefineConstants>
20+
</PropertyGroup>
21+
22+
<PropertyGroup Condition=" '$(TargetFramework)' == 'net461' ">
23+
<DefineConstants>$(DefineConstants);NET_4_0;FEATURE_ADONET_SQLCOMMANDSET;FEATURE_APPDOMAIN;FEATURE_ASSEMBLYBUILDER_SAVE;FEATURE_BINDINGLIST;FEATURE_CODEDOM;FEATURE_DATA_CLOSE;FEATURE_DATA_GETSCHEMATABLE;FEATURE_DBPROVIDERFACTORIES;FEATURE_ODBC_OLEDB;FEATURE_REFLECTEDTYPE;FEATURE_REMOTING;FEATURE_SECURITY_PERMISSIONS;FEATURE_SERIALIZATION;FEATURE_STRING_INTERN;FEATURE_SYSTEM_CONFIGURATION;FEATURE_SYSTEM_SERVICEMODEL;FEATURE_SYSTEM_TRANSACTIONS;FEATURE_WEB_SESSION_CONTEXT;FEATURE_XML_SCHEMAS;FEATURE_XML_VALIDATIONEVENTHANDLER</DefineConstants>
24+
</PropertyGroup>
25+
1826
<ItemGroup>
1927
<None Remove="**\*.g" />
2028
</ItemGroup>
@@ -46,14 +54,6 @@
4654
<PackageReference Include="System.Collections.NonGeneric" Version="4.3.0" />
4755
</ItemGroup>
4856

49-
<PropertyGroup Condition=" '$(TargetFramework)' == 'netstandard1.6' ">
50-
<DefineConstants>$(DefineConstants);NETSTANDARD;FEATURE_DATA_GETCOLUMNSCHEMA;FEATURE_INTERNALIZE_IESI;FEATURE_NETCORE_ICLONEABLE_API;FEATURE_NETCORE_REFLECTION_API</DefineConstants>
51-
</PropertyGroup>
52-
53-
<PropertyGroup Condition=" '$(TargetFramework)' == 'net461' ">
54-
<DefineConstants>$(DefineConstants);NET_4_0;FEATURE_ADONET_SQLCOMMANDSET;FEATURE_APPDOMAIN;FEATURE_ASSEMBLYBUILDER_SAVE;FEATURE_BINDINGLIST;FEATURE_CODEDOM;FEATURE_DATA_CLOSE;FEATURE_DATA_GETSCHEMATABLE;FEATURE_DBPROVIDERFACTORIES;FEATURE_LEGACY_REFLECTION_API;FEATURE_ODBC_OLEDB;FEATURE_REFLECTEDTYPE;FEATURE_REMOTING;FEATURE_SECURITY_PERMISSIONS;FEATURE_SERIALIZATION;FEATURE_STRING_INTERN;FEATURE_SYSTEM_CONFIGURATION;FEATURE_SYSTEM_SERVICEMODEL;FEATURE_SYSTEM_TRANSACTIONS;FEATURE_WEB_SESSION_CONTEXT;FEATURE_XML_SCHEMAS;FEATURE_XML_VALIDATIONEVENTHANDLER</DefineConstants>
55-
</PropertyGroup>
56-
5757
<ItemGroup Condition=" '$(TargetFramework)' == 'net461' ">
5858
<PackageReference Include="Iesi.Collections" Version="4.0.1.4000" />
5959
<Reference Include="System.Data" />

0 commit comments

Comments
 (0)