Merge branch 'master' into use-jsonc-parser

Author: nickdeis

CHANGELOG.md

@@ -1,4 +1,7 @@
 # CHANGELOG
+## 0.7.9
+### Minor
+ - Add support for linting comments
 ## 0.6.9
 ### Patch
  - Add eslint 7 unit testing

index.js

@@ -54,7 +54,7 @@ module.exports = {
           ignoreCase
         } = checkOptions(context.options[0] || {});
         const sourceCode = context.getSourceCode();
-        const comments = sourceCode.getAllComments();
+        
         const allPatterns = Object.assign({}, STANDARD_PATTERNS, additionalRegexes);
         const allDelimiters = additionalDelimiters.concat([" "]);
 
@@ -112,6 +112,10 @@ module.exports = {
           });
         }
 
+        //Check all comments
+        const comments = sourceCode.getAllComments();
+        comments.forEach(comment => checkString(comment.value,comment));
+
         return {
           Literal(node) {
             const { value } = node;

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-no-secrets",
-  "version": "0.7.10",
+  "version": "0.8.10",
   "description": "An eslint rule that searches for potential secrets/keys in code",
   "main": "index.js",
   "scripts": {

package.json

@@ -69,7 +69,12 @@ class A {
 
 const IS_REALLY_A_NAMESPACE_TEST = `
 const NAMESPACE_CLASSNAME = 'Validation.JSONSchemaValidationUtilsImplFactory';
-`
+`;
+
+const COMMENTS_TEST = `
+// const password = "ZWVTjPQSdhwRgl204Hc51YCsritMIzn8B=/p9UyeX7xu6KkAGqfm3FJ+oObLDNEva";
+const password = "";
+`;
 /**
  * Test to make sure regular expressions aren't triggered by the entropy check
  */
@@ -170,6 +175,10 @@ const TESTS = {
     {
       code:SECRET_LOWERCASE_STRING,
       errors:[HIGH_ENTROPY_MSG]
+    },
+    {
+      code: COMMENTS_TEST,
+      errors:[HIGH_ENTROPY_MSG]
     }
   ].concat(PATTERN_MATCH_TESTS)
 };