Skip to content

Commit 6f507aa

Browse files
committed
Merge pull request #270 from matthew-brett/to-relative-imports
MRG: change absolute to relative imports Use relative imports for nibabel modules.
2 parents cc93272 + 2717eca commit 6f507aa

File tree

5 files changed

+15
-18
lines changed

5 files changed

+15
-18
lines changed

nibabel/eulerangles.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -339,7 +339,7 @@ def quat2euler(q):
339339
large.
340340
'''
341341
# delayed import to avoid cyclic dependencies
342-
import nibabel.quaternions as nq
342+
from . import quaternions as nq
343343
return mat2euler(nq.quat2mat(q))
344344

345345

@@ -373,7 +373,7 @@ def euler2angle_axis(z=0, y=0, x=0):
373373
True
374374
'''
375375
# delayed import to avoid cyclic dependencies
376-
import nibabel.quaternions as nq
376+
from . import quaternions as nq
377377
return nq.quat2angle_axis(euler2quat(z, y, x))
378378

379379

@@ -411,6 +411,6 @@ def angle_axis2euler(theta, vector, is_normalized=False):
411411
repetition is large.
412412
'''
413413
# delayed import to avoid cyclic dependencies
414-
import nibabel.quaternions as nq
414+
from . import quaternions as nq
415415
M = nq.angle_axis2mat(theta, vector, is_normalized)
416416
return mat2euler(M)

nibabel/freesurfer/tests/test_io.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
import getpass
55
import time
66

7-
from nibabel.tmpdirs import InTemporaryDirectory
7+
from ...tmpdirs import InTemporaryDirectory
88

99
from nose.tools import assert_true
1010
import numpy as np

nibabel/nicom/dicomreaders.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55

66
import numpy as np
77

8+
from .. import Nifti1Image
89
from .dicomwrappers import (wrapper_from_data, wrapper_from_file)
910

1011

@@ -28,13 +29,12 @@ def mosaic_to_nii(dcm_data):
2829
img : ``Nifti1Image``
2930
Nifti image object
3031
'''
31-
import nibabel as nib
3232
dcm_w = wrapper_from_data(dcm_data)
3333
if not dcm_w.is_mosaic:
3434
raise DicomReadError('data does not appear to be in mosaic format')
3535
data = dcm_w.get_data()
3636
aff = np.dot(DPCS_TO_TAL, dcm_w.get_affine())
37-
return nib.Nifti1Image(data, aff)
37+
return Nifti1Image(data, aff)
3838

3939

4040
def read_mosaic_dwi_dir(dicom_path, globber='*.dcm', dicom_kwargs=None):

nibabel/tests/test_image_api.py

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -27,14 +27,11 @@
2727
_, have_scipy, _ = optional_package('scipy')
2828
_, have_h5py, _ = optional_package('h5py')
2929

30-
from nibabel import (AnalyzeImage, Spm99AnalyzeImage, Spm2AnalyzeImage,
31-
Nifti1Pair, Nifti1Image, Nifti2Pair, Nifti2Image,
32-
MGHImage, Minc1Image, Minc2Image)
33-
from nibabel.spatialimages import SpatialImage
34-
from nibabel.ecat import EcatImage
35-
from nibabel import minc1
36-
from nibabel import minc2
37-
from nibabel import parrec
30+
from .. import (AnalyzeImage, Spm99AnalyzeImage, Spm2AnalyzeImage,
31+
Nifti1Pair, Nifti1Image, Nifti2Pair, Nifti2Image,
32+
MGHImage, Minc1Image, Minc2Image)
33+
from ..spatialimages import SpatialImage
34+
from .. import minc1, minc2, parrec
3835

3936
from nose import SkipTest
4037
from nose.tools import (assert_true, assert_false, assert_raises,
@@ -372,7 +369,7 @@ def loader(self, fname):
372369

373370
# ECAT is a special case and needs more thought
374371
# class TestEcatAPI(TestAnalyzeAPI):
375-
# image_maker = EcatImage
372+
# image_maker = ecat.EcatImage
376373
# has_scaling = True
377374
# can_save = True
378375
# standard_extension = '.v'

nibabel/tests/test_parrec_data.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
import numpy as np
99

10-
import nibabel as nib
10+
from .. import load as top_load
1111
from ..parrec import load
1212

1313
from .nibabel_data import get_nibabel_data, needs_nibabel_data
@@ -39,7 +39,7 @@ def test_loading():
3939
# Compare against NIFTI if present
4040
nifti_fname = pjoin(BALLS, 'NIFTI', par_root + '.nii.gz')
4141
if exists(nifti_fname):
42-
nimg = nib.load(nifti_fname)
42+
nimg = top_load(nifti_fname)
4343
assert_almost_equal(nimg.affine[:3, :3], pimg.affine[:3, :3], 3)
4444
# The translation part is always off by the same ammout
4545
aff_off = pimg.affine[:3, 3] - nimg.affine[:3, 3]
@@ -61,5 +61,5 @@ def test_fieldmap():
6161
fieldmap_par = pjoin(BALLS, 'PARREC', 'fieldmap.PAR')
6262
fieldmap_nii = pjoin(BALLS, 'NIFTI', 'fieldmap.nii.gz')
6363
pimg = load(fieldmap_par)
64-
nimg = nib.load(fieldmap_nii)
64+
nimg = top_load(fieldmap_nii)
6565
raise SkipTest('Fieldmap remains puzzling')

0 commit comments

Comments
 (0)