Skip to content

file constructor in doc/source/devel/register_me.py #1274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DimitriPapadopoulos opened this issue Nov 7, 2023 · 6 comments · Fixed by #1275
Closed

file constructor in doc/source/devel/register_me.py #1274

DimitriPapadopoulos opened this issue Nov 7, 2023 · 6 comments · Fixed by #1275

Comments

@DimitriPapadopoulos
Copy link
Contributor

DimitriPapadopoulos commented Nov 7, 2023

Noticed this code, where file is neither a Python 3 built-in, nor imported:

dsource.write(file(ini_fname, 'wt'))

This looks like a Python 2 left-over:
https://python.readthedocs.io/en/v2.7.2/library/functions.html#file
https://portingguide.readthedocs.io/en/latest/builtins.html#removed-file

Has doc/source/devel/register_me.py ever been run recently? Is it still useful?

@effigies
Copy link
Member

effigies commented Nov 7, 2023

This seems to be something dpkg related. Possibly @yarikoptic or @mih would know what the use case is, but clearly nobody has run this in years. I'm okay to delete it.

@mih
Copy link
Member

mih commented Nov 7, 2023

My initial association was Debian's dpkg, but this is unrelated. I cannot provide any insight. Sorry.

@effigies
Copy link
Member

effigies commented Nov 7, 2023

I'd guess it has something to do with https://nipy.org/nipy/users/install_data.html, then. Which I don't think anybody still uses.

@DimitriPapadopoulos
Copy link
Contributor Author

DimitriPapadopoulos commented Nov 8, 2023

@yarikoptic
Copy link
Member

FWIW

❯ git show --stat ec163399251a7c449a4a54fc660c8504abc0a705
commit ec163399251a7c449a4a54fc660c8504abc0a705
Author: Matthew Brett <[email protected]>
Date:   Mon Dec 6 17:44:08 2010 -0500

    DOC - fleshed out use cases with example code

 doc/source/devel/data_pkg_uses.rst | 254 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 doc/source/devel/register_me.py    |  49 +++++++++++++++++
 2 files changed, 303 insertions(+)

so only @matthew-brett would know for sure. And given that win32 was involved, likely that dpkg has nothing to do with Debian, but rather some ad-hoc "data package" ;)

altogether, if not used ,indeed could be let RiP

@matthew-brett
Copy link
Member

Yes, this was me sketching what we would need to make data packages work - but Pooch has more or less solved this problem now. No problem to delete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants