Skip to content

Commit fdafbde

Browse files
committed
Adjust tests for timing differences on Node 14.7+
Refs: nodejs/node#34636 Refs: nodejs/node#34386
1 parent 463f792 commit fdafbde

File tree

2 files changed

+9
-5
lines changed

2 files changed

+9
-5
lines changed

test/buffer.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
const assert = require('assert');
33
const weak = require('../');
44

5+
const tick = (n, cb) => n === 0 ? cb() : setImmediate(tick, n-1, cb);
6+
57
describe('weak()', function () {
68
afterEach(gc);
79

@@ -14,7 +16,7 @@ describe('weak()', function () {
1416

1517
assert(!called);
1618
gc();
17-
setImmediate(() => {
19+
tick(3, () => {
1820
assert(called);
1921
done();
2022
});

test/callback.js

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
const assert = require('assert');
33
const weak = require('../');
44

5+
const tick = (n, cb) => n === 0 ? cb() : setImmediate(tick, n-1, cb);
6+
57
describe('weak()', function() {
68
afterEach(gc);
79

@@ -18,7 +20,7 @@ describe('weak()', function() {
1820
});
1921
assert(!called);
2022
gc();
21-
setImmediate(() => {
23+
tick(3, () => {
2224
assert(called);
2325
done();
2426
});
@@ -36,7 +38,7 @@ describe('weak()', function() {
3638
called2 = true
3739
});
3840
gc();
39-
setImmediate(() => {
41+
tick(3, () => {
4042
assert(called1);
4143
assert(called2);
4244
done();
@@ -60,7 +62,7 @@ describe('weak()', function() {
6062
called2 = true
6163
});
6264
gc();
63-
setImmediate(() => {
65+
tick(3, () => {
6466
assert.strictEqual(weak.get(r1), undefined);
6567
assert.strictEqual(weak.isDead(r1), true);
6668
assert(called1);
@@ -84,7 +86,7 @@ describe('weak()', function() {
8486
assert(!calledGcCallback);
8587
assert(!calledTickCallback);
8688
gc();
87-
setImmediate(() => {
89+
tick(3, () => {
8890
assert(calledGcCallback);
8991
assert(calledTickCallback);
9092
done();

0 commit comments

Comments
 (0)