fix(use): create package.json when calling corepack use on empty dir#350
Merged
fix(use): create package.json when calling corepack use on empty dir#350
package.json when calling corepack use on empty dir#350Conversation
arcanis
reviewed
Jan 8, 2024
Comment on lines
+103
to
+111
| try { | ||
| file = await fs.promises.open(manifestPath, `r`); | ||
| } catch (err) { | ||
| if ((err as NodeError)?.code === `ENOENT`) continue; | ||
| throw err; | ||
| } | ||
|
|
||
| const content = await fs.promises.readFile(manifestPath, `utf8`); | ||
| const content = await file.readFile(`utf8`); | ||
| await file.close(); |
Contributor
There was a problem hiding this comment.
Can't we just use readFile and assign {} to data wen catching ENOENT?
Contributor
Author
There was a problem hiding this comment.
Sure, the only anti-pattern is to rely on existsSync, as its result might be outdated by the time the readFile calls is processed.
merceyz
reviewed
Jan 10, 2024
arcanis
approved these changes
Jan 11, 2024
Contributor
arcanis
left a comment
arcanis
left a comment
There was a problem hiding this comment.
Couple of nits, but LGTM overall
aduh95
commented
Jan 11, 2024
Co-authored-by: Maël Nison <nison.mael@gmail.com>
merceyz
approved these changes
Jan 12, 2024
Contributor
Author
I chose |
Member
|
Right, in that case I agree, it's a bugfix 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #347