Skip to content

Commit bba0ac0

Browse files
gireeshpunathilHarshithaKP
authored andcommitted
doc: add minutes for meeting 22 Apr 2020
PR-URL: #384 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Harshitha K P <[email protected]>
1 parent dda6787 commit bba0ac0

File tree

1 file changed

+93
-0
lines changed

1 file changed

+93
-0
lines changed

wg-meetings/2020-04-22.md

Lines changed: 93 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,93 @@
1+
# Node.js Diagnostics WorkGroup Meeting 2020-04-22
2+
3+
## Links
4+
5+
* **Recording**: https://www.youtube.com/watch?v=AUL_rA6_Gz4
6+
* **GitHub Issue**: https://github.com/nodejs/diagnostics/issues/381
7+
* **Minutes Google Doc**: https://docs.google.com/document/d/1nBAFxiu3DSbp4yu8meZeIAB5ZLCaazjCU33OU_gHEfA
8+
9+
## Present
10+
11+
* Diagnostics team: @nodejs/diagnostics
12+
* Stephen Belanger @qard
13+
* Michael Dawson (@mhdawson)
14+
* Gireesh Punathil (@gireeshpunathil)
15+
* Chengzhong Wu (@legendecas)
16+
* Peter Marton (@hekike)
17+
* Harshitha K P (@harshithakp)
18+
* Matheus Marchini (@mmarchini)
19+
20+
21+
## Agenda
22+
23+
## Announcements
24+
25+
*Extracted from **diag-agenda** labelled issues and pull requests from the **nodejs org** prior to the meeting.
26+
27+
### nodejs/diagnostics
28+
29+
* Deep dives are pushed out currently because of many topics
30+
* Gireesh: earlier we switched two bi-weekly because of low attendance
31+
* Michael: we could add to calendar
32+
* Peter: should we try this approach and create a deep dive next week and normal meeting after that
33+
* Mattheus: we could always just skip meetings if there is not enough topic
34+
* Stephen: I’d rather meet more frequently than running out of time
35+
* Michael: I’ll add to the calendar
36+
* self nomination to diagnostics working group [#379](https://github.com/nodejs/diagnostics/pull/379)
37+
* Peter: Many approves, what’s the action item here
38+
* Michael: our rules say we to add to agenda for visibility
39+
* Harshitha: working with Gireesh and interested in Diagnostics
40+
* Looking into collaborating more into diagnostics and improving tooling
41+
* Currently interested in Node Report and Heap Profiling
42+
43+
44+
* COVID-19 and WG sittings [#370](https://github.com/nodejs/diagnostics/issues/370)
45+
* No concerns/comments this week
46+
47+
* proposal: elevate diagnostic report to tier1 [#369](https://github.com/nodejs/diagnostics/issues/369)
48+
* Gireesh: Process was approved, raised in main repo now
49+
* After waiting for seven days we could process, but we have only one approval at the moment
50+
* Michael: did I approve?
51+
* Gireesh: One comment about putting back the old report to unclassified
52+
* Michael: sounds good I’ll take a look
53+
* PR, please take look: https://github.com/nodejs/node/pull/32732
54+
55+
* reportVersion semantics are not defined [#349](https://github.com/nodejs/diagnostics/issues/349)
56+
* Mattheus will map schema changes versioning
57+
58+
* Proposal to drive Diagnostics WG initiatives through user journeys [#295](https://github.com/nodejs/diagnostics/issues/295)
59+
* Next week April 29 we will do a deep dive (CPU Profiling)
60+
61+
* Node CPU Profiling Roadmap [#148](https://github.com/nodejs/diagnostics/issues/148)
62+
* Matheus: discussion restarted on the issue about what’s the proper way to do CPU profiling on Node.js
63+
* Today it’s not clear to users which tools are available and supported
64+
* Some concerns around V8 Profiler performance that was raised 2-3 years ago, but it wasn’t tackled
65+
* CPU Profiling always happen on V8, so if we want to improve and make more production safe, we need to engage with V8 team
66+
* I think we need to figure out how to engage with V8 and collaborate on this
67+
* Michael: In theory we could contribute to V8
68+
* Peter: I think next week deep dive will be good starting point for what’s available and gaps
69+
* Michael: we could layout what’s need to be improved with gaps and discuss with them who can work on it
70+
* Gireesh: user journeys could help to identify these gaps and action items
71+
* If you ping V8 team they reply, but they seems less proactively
72+
* Matheus: we should align with V8 before we open PRs
73+
* Matheus: we could also reach out to Chrome Dev Tools team as APIs they have to use are the same we need and maybe they have more resources to work on
74+
* Process plan: collect user journeys on next meeting -> add old items -> write down gaps and requests -> reach out to V8 and Chrome Dev tools -> invite them to our meeting
75+
76+
* \[async_hooks\] stable API - tracking issue [#124](https://github.com/nodejs/diagnostics/issues/124)
77+
* napi_make_callback issue: https://github.com/nodejs/node/pull/32930
78+
* fast-path promise hook: https://github.com/nodejs/node/pull/32891
79+
* reviving zones proposal: https://github.com/nodejs/diagnostics/issues/375
80+
* Stephen: napi_make_callback has an issue, there is a PR but not sure if it’s safe. I could use some eyes, maybe someone with more N-API expertise: it’s swapping out the async struct to a new class and I’m not sure it’s safe
81+
* WG: Approach makes sense, we just need to review PR
82+
* Stephen: fast-promise for promise hook; if there is no destroy hook it will just use JS implementation which doesn’t do GC tracking and emits destroy events. I’ve an open PR, functionality is there, need to solve an issue around the test suite and resolve PR comments.
83+
*Legendecas: zone proposal; we discussed the proposal, question around if error handling should be included in the proposal. Maybe we could present the proposal in TC39, we have to prepare the proposal text before we present (maybe on incubator call of May 12).
84+
* Stephen: various efforts to update domains to use zones. Would we include it in the proposal?
85+
* Legendecas will work on the proposal and would be interested to involve more people
86+
* Michael: it would be a good idea to sync with OpenJS Standard team, people are there involved with TC39
87+
* Legendecas: I can reach out to them
88+
89+
## Q&A, Other
90+
91+
## Upcoming Meetings
92+
93+
* **Node.js Foundation Calendar**: https://nodejs.org/calendar

0 commit comments

Comments
 (0)