-
-
Notifications
You must be signed in to change notification settings - Fork 116
Bot labelled nodejs/node#11583 as meta #127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I actually have no idea. I believe your understanding of the |
All I can go by right now is the current changes in the PR (Github complains about too many requests if I try to go back 23 days in the repo's webhook logs), so AFAICT it's working as expected. That PR (currently) contains changes to these files that would get matched in the regexp:
|
@mscdex the PR now needs a rebase, so I'm sure it does contain changes to those files, it certainly didn't when I opened this issue. Maybe it also did originally too (when the bot added the labels). |
Sounds like there's some chance this actually worked as expected, and sadly not possible to find the list of changed files at the exact moment the bot labelled the PR. Logging everything that happens on a PR would have come in handy: #73 Closing this for now as it seems more or less impossible to have the facts for digging deeper here. |
The bot added the
meta
label to nodejs/node#11583, which as far as I can see didn't touch any of the files specified in lib/node-labels.js#L10-L11, which is:AFAICT this matches
ALLCAPS
or something that starts with one of the listed words in the root.Looks like
meta
labelling was added in #37 so cc/ @Fishrock123Files in nodejs/node#11583:
The text was updated successfully, but these errors were encountered: