Skip to content

Bot labelled nodejs/node#11583 as meta #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gibfahn opened this issue Mar 4, 2017 · 4 comments
Closed

Bot labelled nodejs/node#11583 as meta #127

gibfahn opened this issue Mar 4, 2017 · 4 comments

Comments

@gibfahn
Copy link
Member

gibfahn commented Mar 4, 2017

The bot added the meta label to nodejs/node#11583, which as far as I can see didn't touch any of the files specified in lib/node-labels.js#L10-L11, which is:

  [/^([A-Z]+$|CODE_OF_CONDUCT|ROADMAP|WORKING_GROUPS|GOVERNANCE|CHANGELOG|\.mail|\.git.+)/, 'meta'],

AFAICT this matches ALLCAPS or something that starts with one of the listed words in the root.

Looks like meta labelling was added in #37 so cc/ @Fishrock123


Files in nodejs/node#11583:

image

@Fishrock123
Copy link
Contributor

I actually have no idea.

I believe your understanding of the meta regex is correct.

@mscdex
Copy link
Contributor

mscdex commented Mar 22, 2017

All I can go by right now is the current changes in the PR (Github complains about too many requests if I try to go back 23 days in the repo's webhook logs), so AFAICT it's working as expected. That PR (currently) contains changes to these files that would get matched in the regexp:

  • AUTHORS
  • WORKING_GROUPS.md

@gibfahn
Copy link
Member Author

gibfahn commented Mar 22, 2017

@mscdex the PR now needs a rebase, so I'm sure it does contain changes to those files, it certainly didn't when I opened this issue. Maybe it also did originally too (when the bot added the labels).

@phillipj
Copy link
Member

phillipj commented May 6, 2017

Sounds like there's some chance this actually worked as expected, and sadly not possible to find the list of changed files at the exact moment the bot labelled the PR.

Logging everything that happens on a PR would have come in handy: #73

Closing this for now as it seems more or less impossible to have the facts for digging deeper here.

@phillipj phillipj closed this as completed May 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants