Address review comments

KevinEady · legendecas · KevinEady · commit df4e6b105fd8 · 2024-11-11T21:08:37.000+01:00
Co-authored-by: Chengzhong Wu &lt;legendecas@gmail.com&gt;
diff --git a/napi-inl.h b/napi-inl.h
@@ -150,8 +150,9 @@ inline void WrapVoidCallback(napi_env, Callable callback) {
   }
 #endif  // NODE_ADDON_API_CPP_EXCEPTIONS_ALL
 #else
-  // When C++ exceptions are disabled, errors are immediately thrown as JS
-  // exceptions, so there is no need to catch and rethrow them here.
+  // When C++ exceptions are disabled, there is no need to catch and rethrow C++
+  // exceptions. JS errors should be thrown with
+  // `Error::ThrowAsJavaScriptException`.
   callback();
 #endif  // NODE_ADDON_API_CPP_EXCEPTIONS
 }

Original file line number	Diff line number	Diff line change
`@@ -150,8 +150,9 @@ inline void WrapVoidCallback(napi_env, Callable callback) {`
`150`	`150`	`}`
`151`	`151`	`#endif // NODE_ADDON_API_CPP_EXCEPTIONS_ALL`
`152`	`152`	`#else`
`153`		`- // When C++ exceptions are disabled, errors are immediately thrown as JS`
`154`		`- // exceptions, so there is no need to catch and rethrow them here.`
	`153`	`+ // When C++ exceptions are disabled, there is no need to catch and rethrow C++`
	`154`	`+ // exceptions. JS errors should be thrown with`
	`155`	+ // `Error::ThrowAsJavaScriptException`.
`155`	`156`	`callback();`
`156`	`157`	`#endif // NODE_ADDON_API_CPP_EXCEPTIONS`
`157`	`158`	`}`