Skip to content

Investigate automation of publishing new npm versions #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mhdawson opened this issue Mar 3, 2023 · 5 comments
Closed

Investigate automation of publishing new npm versions #13

mhdawson opened this issue Mar 3, 2023 · 5 comments

Comments

@mhdawson
Copy link
Member

mhdawson commented Mar 3, 2023

Seems like after a PR to update is reviewed/landed we could automate publishing a new version.

@KevinEady
Copy link
Contributor

KevinEady commented May 8, 2024

I can take a look at this.

I am wondering about what we should do with the versioning of our package? Should it match the Node.js version the headers are based on? For example, after merging #40 , we would publish this package as version 22.1.0? I think we had this discussion before but not sure the outcome (if there was one)?

If we don't go with that, what would our versioning scheme be -- just update the minor version every time? From a solution standpoint, this is much easier 😄

What are your thoughts @NickNaso ?

@NickNaso
Copy link
Member

NickNaso commented May 8, 2024

Hi @KevinEady you are right and we decided to follow the rules reported in the section Version of the docs https://github.com/nodejs/node-api-headers?tab=readme-ov-file#versions.
I think that is the simpler thing that we can do.

@KevinEady
Copy link
Contributor

Hi @NickNaso ,

So I see the (semi-)automated release flow going like so:

  • Create new workflow (prepare-release) that:

    • triggers only on main with changes in ['def/*', 'include/*']
    • updates package version via npm version minor
    • updates CHANGELOG.md with the notable changes and commits list since last release tag
    • creates branch release/v<version>
    • commits changes with commit message release: v<version>
    • creates PR with title release: v<version> and body Automated release for version v<version>
  • Create new workflow (publish-release) that:

    • triggers only on main with changes in package.json
    • runs only if package version is not published on npm
    • runs npm publish
    • creates and pushes tag v<version>
    • creates a GitHub Release for new tag with "Whats Changed" as a list of all commits since tag of last published version

I would not want a 100% automatic publishing process, and so this above CI flow would require only one manual step for the release: approving the PR with the version change created by prepare-release. This gives us a chance to make any changes as needed (eg. updating READMEs, adding contributors, ...) before the final publish. Also due to branch protection, we can't write directly into main, which is why some PR must exist.

I am also tempted to not have the publish-release workflow be automatic, and require running the action manually.

Thoughts on all of this?

@NickNaso
Copy link
Member

NickNaso commented May 8, 2024

Hi @KevinEady,
I agree with you maybe we should trigger the publish-release workflow only when a branch release/v<version> is merged or manually.

@legendecas
Copy link
Member

legendecas commented Jul 9, 2024

Automation verified at #45. Thank you all for setting this up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants