Skip to content

Commit 1210673

Browse files
committed
Add notables to commmit msg body
1 parent f68a391 commit 1210673

File tree

3 files changed

+8
-8
lines changed

3 files changed

+8
-8
lines changed

components/git/release.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ async function main(state, argv, cli, req, dir) {
9191
// Check the branch diff to determine if the releaser
9292
// wants to backport any more commits before proceeding.
9393
cli.startSpinner('Fetching branch-diff');
94-
const raw = release.checkBranchDiff();
94+
const raw = release.getBranchDiff();
9595
const diff = raw.split('*');
9696
cli.stopSpinner('Got branch diff');
9797

lib/cli.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ class CLI {
3636
}
3737

3838
// TODO(codebytere): fold this into an options object
39-
// for cli.prompt() ans refactor accordingly.
39+
// for cli.prompt() and refactor accordingly.
4040
async promptInput(question, showSeparator = true) {
4141
if (showSeparator) this.separator();
4242
const { answer } = await inquirer.prompt([{

lib/release.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ class Release {
108108
'`git commit --amend` before proceeding.');
109109

110110
await cli.prompt(
111-
'Type y when you have finished editing the release commit:',
111+
'Finished editing the release commit?',
112112
false);
113113
}
114114

@@ -125,7 +125,7 @@ class Release {
125125
' * https://ci.nodejs.org/job/node-test-pull-request/\n' +
126126
' * https://ci.nodejs.org/job/citgm-smoker/');
127127
cli.info(
128-
'If this release deps/v8 changes, you\'ll also need to run:\n' +
128+
'If this release has deps/v8 changes, you\'ll also need to run:\n' +
129129
' * https://ci.nodejs.org/job/node-test-commit-v8-linux/'
130130
);
131131
}
@@ -253,7 +253,7 @@ class Release {
253253
lastRef
254254
]);
255255

256-
const notableChanges = this.checkBranchDiff(true);
256+
const notableChanges = this.getBranchDiff(true);
257257
const releaseHeader = `## ${date}, Version ${newVersion}` +
258258
` ${releaseInfo}, @${username}\n`;
259259

@@ -334,9 +334,9 @@ class Release {
334334
messageBody.push('This is a security release.\n\n');
335335
}
336336

337+
const notableChanges = this.getBranchDiff(true);
337338
messageBody.push('Notable changes:\n\n');
338-
339-
// TODO(codebytere): add notable changes formatted for plaintext.
339+
messageBody.push(notableChanges);
340340

341341
// Create commit and then allow releaser to amend.
342342
runSync('git', ['add', '.']);
@@ -353,7 +353,7 @@ class Release {
353353
return useMessage;
354354
}
355355

356-
checkBranchDiff(onlyNotableChanges = false) {
356+
getBranchDiff(onlyNotableChanges = false) {
357357
const {
358358
versionComponents,
359359
stagingBranch,

0 commit comments

Comments
 (0)