Better table formatting

Author: codebytere

lib/ci/ci_result_parser.js

@@ -125,11 +125,11 @@ class Job {
     return `https://${CI_DOMAIN}/${path}console`;
   }
 
-  async getBuildData() {
+  async getBuildData(type = 'Build') {
     const { cli, path } = this;
     cli.startSpinner(`Querying data for ${path}`);
     const data = await this.getAPIData();
-    cli.stopSpinner('Build data downloaded');
+    cli.stopSpinner(`${type} data downloaded`);
     return data;
   }
 
@@ -763,7 +763,7 @@ class CITGMBuild extends TestBuild {
   async getResults() {
     let headerData;
     try {
-      headerData = await this.getBuildData();
+      headerData = await this.getBuildData('Header');
     } catch (err) {
       this.failures = [
         new NCUFailure({ url: this.apiUrl }, err.message)
@@ -778,7 +778,7 @@ class CITGMBuild extends TestBuild {
 
     let resultData;
     try {
-      resultData = await this.getBuildData();
+      resultData = await this.getBuildData('Report');
     } catch (err) {
       this.failures = [
         new NCUFailure({ url: this.apiUrl }, err.message)
@@ -818,17 +818,14 @@ class CITGMBuild extends TestBuild {
     const { cli, results } = this;
 
     cli.separator('Failures');
+    const output = {};
     for (const failure of results.failures) {
       const platform = Object.keys(failure)[0];
       const modules = failure[platform].map(f => f.name);
-
-      cli.table(platform, `${modules.length} Failures`, 25);
-      cli.write('\n');
-      cli.table(' '.repeat(11), modules.join('\n' + ' '.repeat(11)));
-      cli.write('\n\n');
+      output[platform] = modules;
     }
 
-    // TODO(codebytere): how to display other builds?
+    console.table(output);
   }
 
   updateAPIVariables() {
@@ -840,10 +837,6 @@ class CITGMBuild extends TestBuild {
     this.displayHeader();
     this.displayBuilds();
   }
-
-  formatAsMarkdown() {
-    // TODO(codebytere): implement.
-  }
 }
 
 function filterBuild(builds, type) {