fixup! ncu-ci: command to start CI for PRs

Author: mmarchini

bin/ncu-ci

@@ -208,11 +208,17 @@ class RunPRJobCommand {
       validArgs = false;
     }
     if (!validArgs) {
-      // this.setExitCode(1);
+      // TODO(mmarchini): change to our API once #443 lands
+      // this.cli.setExitCode(1);
+      process.exitCode = 1;
       return;
     }
     const jobRunner = new RunPRJob(cli, request, owner, repo, prid);
-    return jobRunner.start();
+    if (!jobRunner.start()) {
+      // TODO(mmarchini): change to our API once #443 lands
+      // this.cli.setExitCode(1);
+      process.exitCode = 1;
+    }
   }
 }
 

lib/ci/run_ci.js

@@ -1,6 +1,6 @@
 'use strict';
 
-var FormData = require('form-data');
+const FormData = require('form-data');
 
 const {
   CI_DOMAIN,
@@ -26,7 +26,7 @@ class RunPRJob {
       const { crumb } = await this.request.json(CI_CRUMB_URL);
       return crumb;
     } catch (e) {
-      this.cli.error('Failed to get breadcrumbs');
+      return false;
     }
   }
 
@@ -46,27 +46,32 @@ class RunPRJob {
   }
 
   async start() {
-    this.cli.startSpinner('Validating Jenkins credentials');
+    const { cli } = this;
+    cli.startSpinner('Validating Jenkins credentials');
     const crumb = await this.getCrumb();
 
-    if (!crumb) return;
-    this.cli.stopSpinner('Jenkins credentials valid');
+    if (crumb === false) {
+      cli.stopSpinner('Jenkins credentials invalid',
+        this.cli.SPINNER_STATUS.FAILED);
+      return false;
+    }
+    cli.stopSpinner('Jenkins credentials valid');
 
     try {
-      this.cli.startSpinner('Starting PR CI job');
+      cli.startSpinner('Starting PR CI job');
       await this.request.text(CI_PR_URL, {
         method: 'POST',
         headers: {
           'Jenkins-Crumb': crumb
         },
         body: this.payload
       });
-      this.cli.stopSpinner('Starting PR CI job');
-      this.cli.ok('CI job started');
+      cli.stopSpinner('PR CI job successfully started');
     } catch (err) {
-      this.cli.stopSpinner('');
-      this.cli.error('Failed to start CI');
+      cli.stopSpinner('Failed to start CI', this.cli.SPINNER_STATUS.FAILED);
+      return false;
     }
+    return true;
   }
 }