Skip to content

Commit bdb85a9

Browse files
authored
chore!: remove unmarked DEP0XXX handler (#685)
The deprecation numbers are linted by the `test-doc` test suite, and using `DEP0XXX` would be flagged as invalid before the PR can land.
1 parent 517a259 commit bdb85a9

File tree

3 files changed

+0
-95
lines changed

3 files changed

+0
-95
lines changed

lib/deprecations.js

Lines changed: 0 additions & 50 deletions
This file was deleted.

lib/landing_session.js

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,5 @@
11
import os from 'node:os';
22

3-
import {
4-
getUnmarkedDeprecations,
5-
updateDeprecations
6-
} from './deprecations.js';
73
import {
84
runAsync, runSync, forceRunAsync
95
} from './run.js';
@@ -128,23 +124,6 @@ export default class LandingSession extends Session {
128124
process.exit(1);
129125
}
130126

131-
// Check for and maybe assign any unmarked deprecations in the codebase.
132-
if (this.updateDeprecations !== 'yes') {
133-
const unmarkedDeprecations = await getUnmarkedDeprecations();
134-
const unmarkedDepCount = unmarkedDeprecations.length;
135-
if (unmarkedDepCount > 0) {
136-
cli.startSpinner('Assigning deprecation numbers to DEPOXXX items');
137-
138-
// Update items then stage files and amend the last commit.
139-
await updateDeprecations(unmarkedDeprecations);
140-
await runAsync('git', ['add', 'doc', 'lib', 'src', 'test']);
141-
await runAsync('git', ['commit', '--amend', '--no-edit', ...this.gpgSign]);
142-
143-
cli
144-
.stopSpinner(`Updated ${unmarkedDepCount} DEPOXXX items in codebase`);
145-
}
146-
}
147-
148127
cli.ok('Patches applied');
149128
return commitInfo;
150129
}

lib/prepare_release.js

Lines changed: 0 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,6 @@ import { runAsync, runSync } from './run.js';
99
import { writeJson, readJson } from './file.js';
1010
import Request from './request.js';
1111
import auth from './auth.js';
12-
import {
13-
getUnmarkedDeprecations,
14-
updateDeprecations
15-
} from './deprecations.js';
1612
import {
1713
getEOLDate,
1814
getStartLTSBlurb,
@@ -279,26 +275,6 @@ export default class ReleasePreparation {
279275
await this.updateREPLACEMEs();
280276
cli.stopSpinner('Updated REPLACEME items in docs');
281277

282-
// Check for and maybe assign any unmarked deprecations in the codebase.
283-
const unmarkedDeprecations = await getUnmarkedDeprecations();
284-
const unmarkedDepCount = unmarkedDeprecations.length;
285-
if (unmarkedDepCount > 0) {
286-
if (unmarkedDepCount === 1) {
287-
cli.startSpinner(
288-
'Assigning deprecation number to DEPOXXX item');
289-
await updateDeprecations(unmarkedDeprecations);
290-
cli.stopSpinner('Assigned deprecation numbers to DEPOXXX items');
291-
} else {
292-
cli.warn(
293-
'More than one unmarked DEPOXXX item - manual resolution required.');
294-
295-
await cli.prompt(
296-
`Finished updating ${unmarkedDepCount} unmarked DEPOXXX items?`,
297-
{ defaultAnswer: false });
298-
cli.stopSpinner(`Finished updating ${unmarkedDepCount} DEPOXXX items`);
299-
}
300-
}
301-
302278
// Fetch date to use in release commit & changelogs.
303279
const todayDate = new Date().toISOString().split('T')[0];
304280
this.date = await cli.prompt('Enter release date in YYYY-MM-DD format:',

0 commit comments

Comments
 (0)