Skip to content

commit-queue by pass full CI check rule #909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jakecastelli opened this issue Mar 4, 2025 · 2 comments
Closed

commit-queue by pass full CI check rule #909

jakecastelli opened this issue Mar 4, 2025 · 2 comments

Comments

@jakecastelli
Copy link
Member

jakecastelli commented Mar 4, 2025

There are many instances that a quick typo fix, adding or removing comments either will need a full CI run or land manually (e.g. nodejs/node#57291 (comment)).

Would it possible to add a by pass rule for cq with the following conditions met:

  1. the request-ci label is not present
  2. nodejs bot posts another comment for approval like fast-track (this could be either before cq is added or after)
@richardlau
Copy link
Member

In general adding/removing/editing anything in a source file (including comments) needs a full CI run. This is added protection against, e.g. CVE-2021-42574.

@jakecastelli
Copy link
Member Author

Thanks Richard, TIL 👍

I think this is where another round of approval may help. But I understand and respect the rule.

@jakecastelli jakecastelli closed this as not planned Won't fix, can't repro, duplicate, stale Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants