Skip to content

Commit d70513a

Browse files
doowbbnoordhuis
authored andcommitted
Drop dependency on minimatch.
PR-URL: #1158 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
1 parent fbecb38 commit d70513a

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

lib/install.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ var fs = require('graceful-fs')
2323
, log = require('npmlog')
2424
, semver = require('semver')
2525
, request = require('request')
26-
, minimatch = require('minimatch')
2726
, mkdir = require('mkdirp')
2827
, processRelease = require('./process-release')
2928
, win = process.platform == 'win32'
@@ -395,8 +394,8 @@ function install (fs, gyp, argv, callback) {
395394

396395
function valid (file) {
397396
// header files
398-
return minimatch(file, '*.h', { matchBase: true }) ||
399-
minimatch(file, '*.gypi', { matchBase: true })
397+
var extname = path.extname(file);
398+
return extname === '.h' || extname === '.gypi';
400399
}
401400

402401
/**

package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@
2424
"dependencies": {
2525
"glob": "^7.0.3",
2626
"graceful-fs": "^4.1.2",
27-
"minimatch": "^3.0.2",
2827
"mkdirp": "^0.5.0",
2928
"nopt": "2 || 3",
3029
"npmlog": "0 || 1 || 2 || 3 || 4",

0 commit comments

Comments
 (0)