Skip to content

Commit 2d170ed

Browse files
targosnodejs-github-bot
authored andcommitted
deps: disable V8 concurrent sparkplug compilation
It introduces process hangs on some platforms because Node.js doesn't tear down V8 correctly. Disable it while we work on a solution. Refs: nodejs/node#47297 Refs: https://bugs.chromium.org/p/v8/issues/detail?id=13902 PR-URL: nodejs/node#47450 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
1 parent 10a8430 commit 2d170ed

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

common.gypi

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737

3838
# Reset this number to 0 on major V8 upgrades.
3939
# Increment by one for each non-official patch applied to deps/v8.
40-
'v8_embedder_string': '-node.1',
40+
'v8_embedder_string': '-node.2',
4141

4242
##### V8 defaults for Node.js #####
4343

deps/v8/src/flags/flag-definitions.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1090,7 +1090,7 @@ DEFINE_BOOL(baseline_batch_compilation, true, "batch compile Sparkplug code")
10901090
DEFINE_BOOL_READONLY(concurrent_sparkplug, false,
10911091
"compile Sparkplug code in a background thread")
10921092
#else
1093-
DEFINE_BOOL(concurrent_sparkplug, ENABLE_SPARKPLUG_BY_DEFAULT,
1093+
DEFINE_BOOL(concurrent_sparkplug, false,
10941094
"compile Sparkplug code in a background thread")
10951095
DEFINE_WEAK_IMPLICATION(future, concurrent_sparkplug)
10961096
DEFINE_NEG_IMPLICATION(predictable, concurrent_sparkplug)

0 commit comments

Comments
 (0)