Skip to content

Commit 5d7215e

Browse files
refacknodejs-ci
authored andcommitted
deps: V8: fix BUILDING_V8_SHARED issues
PR-URL: nodejs/node#27375 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]>
1 parent c1e7380 commit 5d7215e

File tree

3 files changed

+6
-1
lines changed

3 files changed

+6
-1
lines changed

common.gypi

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@
3939

4040
# Reset this number to 0 on major V8 upgrades.
4141
# Increment by one for each non-official patch applied to deps/v8.
42-
'v8_embedder_string': '-node.7',
42+
'v8_embedder_string': '-node.8',
4343

4444
##### V8 defaults for Node.js #####
4545

deps/v8/src/objects/ordered-hash-table.cc

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -959,6 +959,7 @@ OrderedHashTableHandler<SmallOrderedNameDictionary,
959959
OrderedNameDictionary>::Allocate(Isolate* isolate,
960960
int capacity);
961961

962+
#if !defined(V8_OS_WIN)
962963
template <class SmallTable, class LargeTable>
963964
bool OrderedHashTableHandler<SmallTable, LargeTable>::Delete(
964965
Isolate* isolate, Handle<HeapObject> table, Handle<Object> key) {
@@ -971,7 +972,9 @@ bool OrderedHashTableHandler<SmallTable, LargeTable>::Delete(
971972
// down to a smaller hash table.
972973
return LargeTable::Delete(isolate, *Handle<LargeTable>::cast(table), *key);
973974
}
975+
#endif
974976

977+
#if !defined(V8_OS_WIN)
975978
template <class SmallTable, class LargeTable>
976979
bool OrderedHashTableHandler<SmallTable, LargeTable>::HasKey(
977980
Isolate* isolate, Handle<HeapObject> table, Handle<Object> key) {
@@ -982,6 +985,7 @@ bool OrderedHashTableHandler<SmallTable, LargeTable>::HasKey(
982985
DCHECK(LargeTable::Is(table));
983986
return LargeTable::HasKey(isolate, LargeTable::cast(*table), *key);
984987
}
988+
#endif
985989

986990
template bool
987991
OrderedHashTableHandler<SmallOrderedHashSet, OrderedHashSet>::HasKey(

deps/v8/src/snapshot/snapshot.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
#include "src/snapshot/partial-serializer.h"
99
#include "src/snapshot/startup-serializer.h"
1010

11+
#include "src/objects/objects-inl.h"
1112
#include "src/utils/utils.h"
1213

1314
namespace v8 {

0 commit comments

Comments
 (0)