Skip to content

Incomplete zlib.gyp #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
targos opened this issue Dec 4, 2019 · 1 comment
Closed

Incomplete zlib.gyp #130

targos opened this issue Dec 4, 2019 · 1 comment

Comments

@targos
Copy link
Member

targos commented Dec 4, 2019

V8 now has a dependency on a Chromium's fork of zlib.
I made a minimal port of the GN file to GYP that works on my Linux machine but it is not enough.

https://github.com/nodejs/node-v8/blob/canary/tools/v8_gypfiles/zlib.gyp
The gyp file for our copy of zlib: https://github.com/nodejs/node-v8/blob/canary/deps/zlib/zlib.gyp

https://ci.nodejs.org/job/node-cross-compile/26378/nodes=cross-compiler-armv7-gcc-6/console

10:49:01 python ./configure --verbose  --dest-cpu=arm
10:49:03 gyp: Dependency '/home/iojs/build/workspace/node-cross-compile/tools/v8_gypfiles/zlib.gyp:zlib#host' not found while trying to load target /home/iojs/build/workspace/node-cross-compile/tools/v8_gypfiles/v8.gyp:v8_base_without_compiler#host
@targos
Copy link
Member Author

targos commented Dec 7, 2019

The include bug is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant