Skip to content

Broken V8 build in test-asan job #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
targos opened this issue Jul 1, 2023 · 2 comments
Closed

Broken V8 build in test-asan job #251

targos opened this issue Jul 1, 2023 · 2 comments

Comments

@targos
Copy link
Member

targos commented Jul 1, 2023

  clang++ -o /home/runner/work/node-v8/node-v8/out/Release/obj.target/v8_compiler/deps/v8/src/compiler/access-builder.o ../deps/v8/src/compiler/access-builder.cc '-D_GLIBCXX_USE_CXX11_ABI=1' '-DNODE_OPENSSL_CONF_NAME=nodejs_conf' '-DNODE_OPENSSL_HAS_QUIC' '-DICU_NO_USER_DATA_OVERRIDE' '-DV8_GYP_BUILD' '-DV8_TYPED_ARRAY_MAX_SIZE_IN_HEAP=64' '-DLEAK_SANITIZER' '-DV8_USE_ADDRESS_SANITIZER' '-D__STDC_FORMAT_MACROS' '-DOPENSSL_NO_PINSHARED' '-DOPENSSL_THREADS' '-DV8_TARGET_ARCH_X64' '-DV8_HAVE_TARGET_OS' '-DV8_TARGET_OS_LINUX' '-DV8_EMBEDDER_STRING="-node.3"' '-DENABLE_DISASSEMBLER' '-DV8_PROMISE_INTERNAL_FIELD_COUNT=1' '-DV8_ENABLE_PRIVATE_MAPPING_FORK_OPTIMIZATION' '-DV8_SHORT_BUILTIN_CALLS' '-DOBJECT_PRINT' '-DV8_INTL_SUPPORT' '-DV8_ATOMIC_OBJECT_FIELD_WRITES' '-DV8_ENABLE_LAZY_SOURCE_POSITIONS' '-DV8_USE_SIPHASH' '-DV8_SHARED_RO_HEAP' '-DV8_WIN64_UNWINDING_INFO' '-DV8_ENABLE_REGEXP_INTERPRETER_THREADED_DISPATCH' '-DV8_USE_ZLIB' '-DV8_ENABLE_TURBOFAN' '-DV8_ENABLE_WEBASSEMBLY' '-DV8_ENABLE_JAVASCRIPT_PROMISE_HOOKS' '-DV8_ALLOCATION_FOLDING' '-DV8_ALLOCATION_SITE_TRACKING' '-DV8_SCRIPTORMODULE_LEGACY_LIFETIME' '-DV8_ADVANCED_BIGINT_ALGORITHMS' '-DUCONFIG_NO_SERVICE=1' '-DU_ENABLE_DYLOAD=0' '-DU_STATIC_IMPLEMENTATION=1' '-DU_HAVE_STD_STRING=1' '-DUCONFIG_NO_BREAK_ITERATION=0' -I../deps/v8 -I../deps/v8/include -I/home/runner/work/node-v8/node-v8/out/Release/obj/gen/generate-bytecode-output-root -I/home/runner/work/node-v8/node-v8/out/Release/obj/gen -I../deps/icu-small/source/i18n -I../deps/icu-small/source/common  -fno-omit-frame-pointer -fsanitize=address -fsanitize-address-use-after-scope -pthread -Wno-unused-parameter -m64 -Wno-return-type -Wno-invalid-offsetof -fno-strict-aliasing -m64 -fno-omit-frame-pointer -fdata-sections -ffunction-sections -O2 -fno-rtti -fno-exceptions -std=gnu++17 -MMD -MF /home/runner/work/node-v8/node-v8/out/Release/.deps//home/runner/work/node-v8/node-v8/out/Release/obj.target/v8_compiler/deps/v8/src/compiler/access-builder.o.d.raw   -c
In file included from ../deps/v8/src/compiler/access-builder.cc:14:
In file included from ../deps/v8/src/objects/objects-inl.h:32:
In file included from ../deps/v8/src/objects/js-proxy-inl.h:8:
In file included from ../deps/v8/src/objects/instance-type-inl.h:11:
In file included from ../deps/v8/src/objects/map-inl.h:9:
In file included from ../deps/v8/src/objects/api-callbacks-inl.h:13:
In file included from ../deps/v8/src/objects/js-objects-inl.h:18:
In file included from ../deps/v8/src/objects/lookup-inl.h:14:
In file included from ../deps/v8/src/heap/factory-inl.h:13:
In file included from ../deps/v8/src/execution/isolate-inl.h:9:
In file included from ../deps/v8/src/objects/contexts-inl.h:17:
../deps/v8/src/objects/ordered-hash-table-inl.h:210:3: error: member reference type 'Tagged' is not a pointer
  WRITE_BARRIER(*this, entry_offset, value);
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../deps/v8/src/objects/object-macros.h:514:50: note: expanded from macro 'WRITE_BARRIER'
    CombinedWriteBarrier(object, Tagged(object)->RawField(offset), value, \
                                 ~~~~~~~~~~~~~~  ^
1 error generated.
make[2]: *** [tools/v8_gypfiles/v8_compiler.target.mk:314: /home/runner/work/node-v8/node-v8/out/Release/obj.target/v8_compiler/deps/v8/src/compiler/access-builder.o] Error 1
@targos targos changed the title Broken V8 build Broken V8 build in test-asan job Jul 4, 2023
@targos
Copy link
Member Author

targos commented Jul 4, 2023

This only happens with the test-asan job.
See https://github.com/nodejs/node-v8/actions/runs/5442226558/jobs/9897172277

@targos
Copy link
Member Author

targos commented Jul 9, 2023

Moved to nodejs/node#48710 (comment)

@targos targos closed this as completed Jul 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant