Skip to content

coverage issues on canary #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bcoe opened this issue Dec 26, 2018 · 1 comment
Closed

coverage issues on canary #97

bcoe opened this issue Dec 26, 2018 · 1 comment
Assignees

Comments

@bcoe
Copy link

bcoe commented Dec 26, 2018

  • Version: v12.0.0-pre
  • Platform: OSX
  • Subsystem: process

I'm trying to test some changes @schuay, @hashseed, and I have been working on for block coverage, and I noticed some regressions on this branch with relation to coverage handling:

  1. in internal/process/coverage.js, coverageDirectory is now undefined when entering the writeCoverage method; this suggests that writeCoverage is perhaps happening in a different threads than before?

  2. if I go ahead and initialize coverageDirectory, coverageConnection.dispatch appears to hang indefinitely.

Not sure if this is due to upstream changes in v8, or downstream changes in Node.js.

@bcoe
Copy link
Author

bcoe commented Dec 31, 2018

I've confirmed that the fix being discussed on nodejs/node corrects this issue.

@bcoe bcoe closed this as completed Dec 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants