Skip to content

Commit 1ef2811

Browse files
sam-githubBridgeAR
authored andcommitted
test: only assert on first lines of TLS trace
The TLS trace data is best-effort, and enough can be dropped from pipe buffers that only the start of the trace is detected. Only assert on the first line of the trace, it should not get dropped, and it's enough to check that trace was enabled via CLI. PR-URL: #28043 Fixes: #27636 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
1 parent 9dd4813 commit 1ef2811

File tree

2 files changed

+0
-3
lines changed

2 files changed

+0
-3
lines changed

test/parallel/parallel.status

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,6 @@ prefix parallel
99
test-net-connect-options-port: PASS,FLAKY
1010
# https://github.com/nodejs/node/issues/26401
1111
test-worker-prof: PASS,FLAKY
12-
# https://github.com/nodejs/node/issues/27553
13-
test-tls-enable-trace-cli: PASS,FLAKY
1412

1513
[$system==win32]
1614
test-http2-pipe: PASS,FLAKY

test/parallel/test-tls-enable-trace-cli.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ child.on('close', common.mustCall((code, signal) => {
3737
assert.strictEqual(stdout.trim(), '');
3838
assert(/Warning: Enabling --trace-tls can expose sensitive/.test(stderr));
3939
assert(/Sent Record/.test(stderr));
40-
assert(/Received Record/.test(stderr));
4140
}));
4241

4342
function test() {

0 commit comments

Comments
 (0)