Skip to content

Commit 33cd51e

Browse files
TrottMylesBorins
authored andcommitted
tools: update tooling to work with new macOS CLI …
Using High Sierra and `xcode-select --install` without installing full Xcode, our build tooling breaks due to faulty regular expressions. Update the `configure` script in our project root directory to handle multi-digit version numbers. `tools/gyp` and `deps/npm/node_modules/node-gyp` still need to be updated for a complete fix. PR-URL: #21173 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent 16661e6 commit 33cd51e

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

configure

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -610,7 +610,7 @@ def get_llvm_version(cc):
610610

611611
def get_xcode_version(cc):
612612
return get_version_helper(
613-
cc, r"(^Apple LLVM version) ([5-9]\.[0-9]+)")
613+
cc, r"(^Apple LLVM version) ([0-9]+\.[0-9]+)")
614614

615615
def get_gas_version(cc):
616616
try:

0 commit comments

Comments
 (0)