Skip to content

Commit 3a7f106

Browse files
committed
net: remove hot path comment from connect
This comment was added with an assumption that we could determine the IP address that localhost should resolve to without performing a lookup. This was a false assumption and should be removed. PR-URL: #4648 Reviewed-By: Brian White <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
1 parent 0f3d75e commit 3a7f106

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

lib/net.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -933,7 +933,6 @@ function lookupAndConnect(self, options) {
933933
port |= 0;
934934

935935
// If host is an IP, skip performing a lookup
936-
// TODO(evanlucas) should we hot path this for localhost?
937936
var addressType = exports.isIP(host);
938937
if (addressType) {
939938
process.nextTick(function() {

0 commit comments

Comments
 (0)