Skip to content

Commit 3ab070d

Browse files
targosMylesBorins
authored andcommitted
deps: backport dfb8d33 from V8 upstream
Original commit message: Reduce the memory footprint of expression classifiers This patch attempts to reduce the (stack) memory footprint of expression classifiers. Instead of keeping space in each classifier for all possible error messages that will (potentially) be reported, if an expression turns out to be a pattern or a non-pattern, such error messages are placed in a list shared by the FunctionState and each classifier keeps a couple of indices in this list. This requires that classifiers are used strictly in a stack-based fashion, which is also in line with my previous patch for revisiting non-pattern rewriting. [email protected] BUG=chromium:528697 Review-Url: https://codereview.chromium.org/1708193003 Cr-Commit-Position: refs/heads/master@{#36897} Fixes: #11480 PR-URL: #11483 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Myles Borins <[email protected]>
1 parent b5fb9f4 commit 3ab070d

File tree

7 files changed

+288
-157
lines changed

7 files changed

+288
-157
lines changed

deps/v8/include/v8-version.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
#define V8_MAJOR_VERSION 5
1212
#define V8_MINOR_VERSION 1
1313
#define V8_BUILD_NUMBER 281
14-
#define V8_PATCH_LEVEL 94
14+
#define V8_PATCH_LEVEL 95
1515

1616
// Use 1 for candidates and 0 otherwise.
1717
// (Boolean macro values are not supported by all preprocessors.)

deps/v8/src/messages.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -449,6 +449,8 @@ class CallSite {
449449
"Too many arguments in function call (only 65535 allowed)") \
450450
T(TooManyParameters, \
451451
"Too many parameters in function definition (only 65535 allowed)") \
452+
T(TooManySpreads, \
453+
"Literal containing too many nested spreads (up to 65534 allowed)") \
452454
T(TooManyVariables, "Too many variables declared (only 4194303 allowed)") \
453455
T(TypedArrayTooShort, \
454456
"Derived TypedArray constructor created an array which was too small") \

0 commit comments

Comments
 (0)