Skip to content

Commit 45d7a19

Browse files
committed
fixup: cleanup after code merge
Second merge fix Let's see if this is all that was needed Final final
1 parent 4f89c9d commit 45d7a19

File tree

3 files changed

+5
-136
lines changed

3 files changed

+5
-136
lines changed

configure.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -357,6 +357,7 @@
357357
shared_optgroup.add_argument('--shared-uvwasi',
358358
action='store_true',
359359
dest='shared_uvwasi',
360+
default=None,
360361
help='link to a shared uvwasi DLL instead of static linking')
361362

362363
shared_optgroup.add_argument('--shared-uvwasi-includes',

node.gyp

Lines changed: 0 additions & 136 deletions
Original file line numberDiff line numberDiff line change
@@ -163,14 +163,6 @@
163163
'deps/histogram/histogram.gyp:histogram',
164164
],
165165

166-
'conditions': [
167-
[ 'node_shared_uvwasi=="false"', {
168-
'dependencies': [
169-
'deps/uvwasi/uvwasi.gyp:uvwasi'
170-
],
171-
}],
172-
],
173-
174166
'msvs_settings': {
175167
'VCLinkerTool': {
176168
'GenerateMapFile': 'true', # /MAP
@@ -462,14 +454,6 @@
462454
'deps/histogram/histogram.gyp:histogram',
463455
],
464456

465-
'conditions': [
466-
[ 'node_shared_uvwasi=="false"', {
467-
'dependencies': [
468-
'deps/uvwasi/uvwasi.gyp:uvwasi'
469-
],
470-
}],
471-
],
472-
473457
'sources': [
474458
'src/api/async_resource.cc',
475459
'src/api/callback.cc',
@@ -927,18 +911,6 @@
927911
'dependencies': [
928912
'<(node_lib_target_name)',
929913
'deps/histogram/histogram.gyp:histogram',
930-
'node_dtrace_header',
931-
'node_dtrace_ustack',
932-
'node_dtrace_provider',
933-
'deps/uvwasi/uvwasi.gyp:uvwasi',
934-
],
935-
936-
'conditions': [
937-
[ 'node_shared_uvwasi=="false"', {
938-
'dependencies': [
939-
'deps/uvwasi/uvwasi.gyp:uvwasi'
940-
],
941-
}],
942914
],
943915

944916
'includes': [
@@ -953,14 +925,6 @@
953925
'test/cctest',
954926
],
955927

956-
'conditions': [
957-
[ 'node_shared_uvwasi=="false"', {
958-
'include_dirs': [
959-
'deps/uvwasi/include',
960-
],
961-
}],
962-
],
963-
964928
'defines': [
965929
'NODE_ARCH="<(target_arch)"',
966930
'NODE_PLATFORM="<(OS)"',
@@ -990,18 +954,6 @@
990954
'deps/googletest/googletest.gyp:gtest',
991955
'deps/googletest/googletest.gyp:gtest_main',
992956
'deps/histogram/histogram.gyp:histogram',
993-
'node_dtrace_header',
994-
'node_dtrace_ustack',
995-
'node_dtrace_provider',
996-
'deps/uvwasi/uvwasi.gyp:uvwasi',
997-
],
998-
999-
'conditions': [
1000-
[ 'node_shared_uvwasi=="false"', {
1001-
'dependencies': [
1002-
'deps/uvwasi/uvwasi.gyp:uvwasi'
1003-
],
1004-
}],
1005957
],
1006958

1007959
'includes': [
@@ -1017,14 +969,6 @@
1017969
'test/cctest',
1018970
],
1019971

1020-
'conditions': [
1021-
[ 'node_shared_uvwasi=="false"', {
1022-
'include_dirs': [
1023-
'deps/uvwasi/include',
1024-
],
1025-
}],
1026-
],
1027-
1028972
'defines': [
1029973
'NODE_ARCH="<(target_arch)"',
1030974
'NODE_PLATFORM="<(OS)"',
@@ -1103,18 +1047,6 @@
11031047
'dependencies': [
11041048
'<(node_lib_target_name)',
11051049
'deps/histogram/histogram.gyp:histogram',
1106-
'node_dtrace_header',
1107-
'node_dtrace_ustack',
1108-
'node_dtrace_provider',
1109-
'deps/uvwasi/uvwasi.gyp:uvwasi',
1110-
],
1111-
1112-
'conditions': [
1113-
[ 'node_shared_uvwasi=="false"', {
1114-
'dependencies': [
1115-
'deps/uvwasi/uvwasi.gyp:uvwasi'
1116-
],
1117-
}],
11181050
],
11191051

11201052
'includes': [
@@ -1130,14 +1062,6 @@
11301062
'test/embedding',
11311063
],
11321064

1133-
'conditions': [
1134-
[ 'node_shared_uvwasi=="false"', {
1135-
'include_dirs': [
1136-
'deps/uvwasi/include',
1137-
],
1138-
}],
1139-
],
1140-
11411065
'sources': [
11421066
'src/node_snapshot_stub.cc',
11431067
'test/embedding/embedtest.cc',
@@ -1170,50 +1094,6 @@
11701094
'target_name': 'overlapped-checker',
11711095
'type': 'executable',
11721096

1173-
'dependencies': [
1174-
'<(node_lib_target_name)',
1175-
'deps/histogram/histogram.gyp:histogram',
1176-
],
1177-
1178-
'conditions': [
1179-
[ 'node_shared_uvwasi=="false"', {
1180-
'dependencies': [
1181-
'deps/uvwasi/uvwasi.gyp:uvwasi'
1182-
],
1183-
}],
1184-
],
1185-
1186-
'includes': [
1187-
'node.gypi'
1188-
],
1189-
1190-
'include_dirs': [
1191-
'src',
1192-
'tools/msvs/genfiles',
1193-
'deps/v8/include',
1194-
'deps/cares/include',
1195-
'deps/uv/include',
1196-
],
1197-
1198-
'conditions': [
1199-
[ 'node_shared_uvwasi=="false"', {
1200-
'include_dirs': [
1201-
'deps/uvwasi/include',
1202-
],
1203-
}],
1204-
],
1205-
1206-
'defines': [
1207-
'NODE_WANT_INTERNALS=1'
1208-
],
1209-
'sources': [
1210-
'src/node_snapshot_stub.cc',
1211-
'src/node_code_cache_stub.cc',
1212-
'tools/code_cache/mkcodecache.cc',
1213-
'tools/code_cache/cache_builder.cc',
1214-
'tools/code_cache/cache_builder.h',
1215-
],
1216-
12171097
'conditions': [
12181098
['OS=="win"', {
12191099
'sources': [
@@ -1235,14 +1115,6 @@
12351115
'<(node_lib_target_name)',
12361116
'deps/histogram/histogram.gyp:histogram',
12371117
],
1238-
1239-
'conditions': [
1240-
[ 'node_shared_uvwasi=="false"', {
1241-
'dependencies': [
1242-
'deps/uvwasi/uvwasi.gyp:uvwasi'
1243-
],
1244-
}],
1245-
],
12461118

12471119
'includes': [
12481120
'node.gypi'
@@ -1256,14 +1128,6 @@
12561128
'deps/uv/include',
12571129
],
12581130

1259-
'conditions': [
1260-
[ 'node_shared_uvwasi=="false"', {
1261-
'include_dirs': [
1262-
'deps/uvwasi/include',
1263-
],
1264-
}],
1265-
],
1266-
12671131
'defines': [ 'NODE_WANT_INTERNALS=1' ],
12681132

12691133
'sources': [

node.gypi

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -196,6 +196,10 @@
196196
],
197197
}],
198198

199+
[ 'node_shared_uvwasi=="false"', {
200+
'dependencies': [ 'deps/uvwasi/uvwasi.gyp:uvwasi' ],
201+
}],
202+
199203
[ 'node_shared_nghttp2=="false"', {
200204
'dependencies': [ 'deps/nghttp2/nghttp2.gyp:nghttp2' ],
201205
}],

0 commit comments

Comments
 (0)