Skip to content

Commit 52a7873

Browse files
nodejs-github-bottargos
authored andcommitted
deps: patch V8 to 12.4.254.19
Refs: v8/v8@12.4.254.18...12.4.254.19 PR-URL: #53094 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Richard Lau <[email protected]>
1 parent 2859f4c commit 52a7873

File tree

2 files changed

+8
-7
lines changed

2 files changed

+8
-7
lines changed

deps/v8/include/v8-version.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
#define V8_MAJOR_VERSION 12
1212
#define V8_MINOR_VERSION 4
1313
#define V8_BUILD_NUMBER 254
14-
#define V8_PATCH_LEVEL 18
14+
#define V8_PATCH_LEVEL 19
1515

1616
// Use 1 for candidates and 0 otherwise.
1717
// (Boolean macro values are not supported by all preprocessors.)

deps/v8/src/ic/ic.cc

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2377,15 +2377,16 @@ Handle<Object> KeyedStoreIC::StoreElementHandler(
23772377
isolate()),
23782378
IsStoreInArrayLiteralIC());
23792379

2380-
if (IsJSProxyMap(*receiver_map)) {
2380+
if (!IsJSObjectMap(*receiver_map)) {
23812381
// DefineKeyedOwnIC, which is used to define computed fields in instances,
2382-
// should be handled by the slow stub.
2383-
if (IsDefineKeyedOwnIC()) {
2384-
TRACE_HANDLER_STATS(isolate(), KeyedStoreIC_SlowStub);
2385-
return StoreHandler::StoreSlow(isolate(), store_mode);
2382+
// should handled by the slow stub below instead of the proxy stub.
2383+
if (IsJSProxyMap(*receiver_map) && !IsDefineKeyedOwnIC()) {
2384+
return StoreHandler::StoreProxy(isolate());
23862385
}
23872386

2388-
return StoreHandler::StoreProxy(isolate());
2387+
// Wasm objects or other kind of special objects go through the slow stub.
2388+
TRACE_HANDLER_STATS(isolate(), KeyedStoreIC_SlowStub);
2389+
return StoreHandler::StoreSlow(isolate(), store_mode);
23892390
}
23902391

23912392
// TODO(ishell): move to StoreHandler::StoreElement().

0 commit comments

Comments
 (0)