Skip to content

Commit 555ba61

Browse files
richardlaucodebytere
authored andcommitted
build: fix compiling addons with older versions of Node.js
`common.gypi` is used by `node-gyp` to compile addons. Default values must be provided for variables that may not exist on older versions of Node.js so that older versions of Node.js can be used to compile addons for later versions of Node.js. Add default values for `v8_enable_pointer_compression` and `v8_enable_31bit_smis_on_64bit_arch`. PR-URL: #33688 Refs: #30463 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Signed-off-by: Richard Lau <[email protected]>
1 parent 69291e4 commit 555ba61

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

common.gypi

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,12 @@
5858
# https://github.com/nodejs/node/pull/22920/files#r222779926
5959
'v8_enable_handle_zapping': 0,
6060

61+
# Disable pointer compression. Can be enabled at build time via configure
62+
# options but default values are required here as this file is also used by
63+
# node-gyp to build addons.
64+
'v8_enable_pointer_compression%': 0,
65+
'v8_enable_31bit_smis_on_64bit_arch%': 0,
66+
6167
# Disable V8 untrusted code mitigations.
6268
# See https://github.com/v8/v8/wiki/Untrusted-code-mitigations
6369
'v8_untrusted_code_mitigations': 0,

0 commit comments

Comments
 (0)