Skip to content

Commit 5b40e2f

Browse files
VoltrexKeyvatargos
authored andcommitted
events: use nullish coalencing operator
PR-URL: #38328 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]>
1 parent 8590c15 commit 5b40e2f

File tree

2 files changed

+15
-5
lines changed

2 files changed

+15
-5
lines changed

benchmark/events/ee-add-remove.js

Lines changed: 14 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,26 @@
11
'use strict';
22
const common = require('../common.js');
3-
const events = require('events');
3+
const { EventEmitter } = require('events');
44

5-
const bench = common.createBenchmark(main, { n: [1e6] });
5+
const bench = common.createBenchmark(main, {
6+
newListener: [0, 1],
7+
removeListener: [0, 1],
8+
n: [1e6],
9+
});
610

7-
function main({ n }) {
8-
const ee = new events.EventEmitter();
11+
function main({ newListener, removeListener, n }) {
12+
const ee = new EventEmitter();
913
const listeners = [];
1014

1115
for (let k = 0; k < 10; k += 1)
1216
listeners.push(() => {});
1317

18+
if (newListener === 1)
19+
ee.on('newListener', (event, listener) => {});
20+
21+
if (removeListener === 1)
22+
ee.on('removeListener', (event, listener) => {});
23+
1424
bench.start();
1525
for (let i = 0; i < n; i += 1) {
1626
const dummy = (i % 2 === 0) ? 'dummy0' : 'dummy1';

lib/events.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -406,7 +406,7 @@ function _addListener(target, type, listener, prepend) {
406406
// adding it to the listeners, first emit "newListener".
407407
if (events.newListener !== undefined) {
408408
target.emit('newListener', type,
409-
listener.listener ? listener.listener : listener);
409+
listener.listener ?? listener);
410410

411411
// Re-assign `events` because a newListener handler could have caused the
412412
// this._events to be assigned to a new object

0 commit comments

Comments
 (0)