buffer: optimize createFromString

PR-URL: #54324

Author: ronag

lib/buffer.js

@@ -150,11 +150,12 @@ const constants = ObjectDefineProperties({}, {
 });
 
 Buffer.poolSize = 8 * 1024;
-let poolSize, poolOffset, allocPool;
+let poolSize, poolOffset, allocPool, allocBuffer;
 
 function createPool() {
   poolSize = Buffer.poolSize;
-  allocPool = createUnsafeBuffer(poolSize).buffer;
+  allocBuffer = createUnsafeBuffer(poolSize);
+  allocPool = allocBuffer.buffer;
   markAsUntransferable(allocPool);
   poolOffset = 0;
 }
@@ -441,28 +442,64 @@ function allocate(size) {
   return createUnsafeBuffer(size);
 }
 
+// function fromStringFast(string, ops) {
+//   let length = string.length;
+
+//   if (length > Buffer.poolSize) {
+//     return createFromString(string, ops.encodingVal);
+//   }
+
+//   length <<= 2; // max utf8 byte length
+
+//   if (length > Buffer.poolSize) {
+//     length = ops.byteLength(string);
+//     if (length > (Buffer.poolSize >>> 1)) {
+//       return createFromString(string, ops.encodingVal);
+//     }
+//   }
+
+//   if (length > (poolSize - poolOffset)) {
+//     createPool();
+//   }
+
+//   const actual = ops.write(allocBuffer, string, poolOffset, length);
+//   const b = new FastBuffer(allocPool, poolOffset, actual);
+
+//   poolOffset += actual;
+//   alignPool();
+
+//   return b;
+// }
+
+
 function fromStringFast(string, ops) {
-  const length = ops.byteLength(string);
+  let length = string.length;
+
+  if (length > Buffer.poolSize)
+    return createFromString(string, ops.encodingVal);
+
+  length <<= 2; // max utf8 byte length
+
+  if (length >= (Buffer.poolSize >>> 1))
+    length = ops.byteLength(string);
 
   if (length >= (Buffer.poolSize >>> 1))
     return createFromString(string, ops.encodingVal);
 
   if (length > (poolSize - poolOffset))
     createPool();
-  let b = new FastBuffer(allocPool, poolOffset, length);
-  const actual = ops.write(b, string, 0, length);
-  if (actual !== length) {
-    // byteLength() may overestimate. That's a rare case, though.
-    b = new FastBuffer(allocPool, poolOffset, actual);
-  }
+
+  const actual = ops.write(allocBuffer, string, poolOffset, length);
+  const b = new FastBuffer(allocPool, poolOffset, actual);
+
   poolOffset += actual;
   alignPool();
   return b;
 }
 
 function fromString(string, encoding) {
   let ops;
-  if (typeof encoding !== 'string' || encoding.length === 0) {
+  if (!encoding || encoding === 'utf8' || typeof encoding !== 'string') {
     if (string.length === 0)
       return new FastBuffer();
     ops = encodingOps.utf8;