crypto: fix memory leak in sign()

tniessen · tniessen · commit 65dfd3073954 · 2019-11-19T14:25:43.000-04:00
diff --git a/src/node_crypto.cc b/src/node_crypto.cc
@@ -5053,6 +5053,8 @@ static AllocatedBuffer ConvertSignatureToP1363(Environment* env,
   CHECK_EQ(n, BN_bn2binpad(r, data, n));
   CHECK_EQ(n, BN_bn2binpad(s, data + n, n));
 
+  ECDSA_SIG_free(asn1_sig);
+
   return buf;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -5053,6 +5053,8 @@ static AllocatedBuffer ConvertSignatureToP1363(Environment* env,`
`5053`	`5053`	`CHECK_EQ(n, BN_bn2binpad(r, data, n));`
`5054`	`5054`	`CHECK_EQ(n, BN_bn2binpad(s, data + n, n));`
`5055`	`5055`
	`5056`	`+ ECDSA_SIG_free(asn1_sig);`
	`5057`	`+`
`5056`	`5058`	`return buf;`
`5057`	`5059`	`}`
`5058`	`5060`