Skip to content

Commit 688078b

Browse files
committed
test_runner: fix spec skip detection
PR-URL: #47537 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
1 parent 2c2b6d1 commit 688078b

File tree

5 files changed

+579
-11
lines changed

5 files changed

+579
-11
lines changed

lib/internal/test_runner/runner.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -189,9 +189,9 @@ class FileTest extends Test {
189189
let directive;
190190

191191
if (skip) {
192-
directive = this.reporter.getSkip(node.reason);
192+
directive = this.reporter.getSkip(node.reason || true);
193193
} else if (todo) {
194-
directive = this.reporter.getTodo(node.reason);
194+
directive = this.reporter.getTodo(node.reason || true);
195195
} else {
196196
directive = kEmptyObject;
197197
}

test/fixtures/test-runner/output/spec_reporter.snapshot

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,7 @@
150150
test with a name and options provided (*ms) # SKIP
151151
functionAndOptions (*ms) # SKIP
152152
escaped description \ # \#\
153-
 (*ms)
153+
 (*ms)
154154
escaped skip message (*ms) # SKIP
155155
escaped todo message (*ms)
156156
escaped diagnostic (*ms)
Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
// Flags: --no-warnings
2+
'use strict';
3+
require('../../../common');
4+
const fixtures = require('../../../common/fixtures');
5+
const spawn = require('node:child_process').spawn;
6+
7+
const child = spawn(process.execPath,
8+
['--no-warnings', '--test', '--test-reporter', 'spec', fixtures.path('test-runner/output/output.js')],
9+
{ stdio: 'pipe' });
10+
// eslint-disable-next-line no-control-regex
11+
child.stdout.on('data', (d) => process.stdout.write(d.toString().replace(/[^\x00-\x7F]/g, '').replace(/\u001b\[\d+m/g, '')));
12+
child.stderr.pipe(process.stderr);

0 commit comments

Comments
 (0)