Skip to content

Commit 893999e

Browse files
dario-piotrowicztargos
authored andcommitted
src: replace V8 Fast API todo comment with note comment
PR-URL: #58614 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
1 parent d596803 commit 893999e

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

src/node_blob.cc

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -450,7 +450,8 @@ void Blob::StoreDataObject(const FunctionCallbackInfo<Value>& args) {
450450
std::string(*type, type.length())));
451451
}
452452

453-
// TODO(@anonrig): Add V8 Fast API to the following function
453+
// Note: applying the V8 Fast API to the following function does not produce
454+
// performance benefits (ref: https://github.com/nodejs/node/pull/58544)
454455
void Blob::RevokeObjectURL(const FunctionCallbackInfo<Value>& args) {
455456
CHECK_GE(args.Length(), 1);
456457
CHECK(args[0]->IsString());

0 commit comments

Comments
 (0)