Skip to content

Commit 9686153

Browse files
mertcanaltintargos
authored andcommitted
stream: fix util.inspect for compression/decompressionStream
PR-URL: #52283 Fixes: #52263 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Daeyeon Jeong <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Matthew Aitken <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Deokjin Kim <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
1 parent 4573231 commit 9686153

File tree

2 files changed

+43
-2
lines changed

2 files changed

+43
-2
lines changed

lib/internal/webstreams/compression.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ class CompressionStream {
9494
[kInspect](depth, options) {
9595
if (!isCompressionStream(this))
9696
throw new ERR_INVALID_THIS('CompressionStream');
97-
customInspect(depth, options, 'CompressionStream', {
97+
return customInspect(depth, options, 'CompressionStream', {
9898
readable: this[kTransform].readable,
9999
writable: this[kTransform].writable,
100100
});
@@ -146,7 +146,7 @@ class DecompressionStream {
146146
[kInspect](depth, options) {
147147
if (!isDecompressionStream(this))
148148
throw new ERR_INVALID_THIS('DecompressionStream');
149-
customInspect(depth, options, 'DecompressionStream', {
149+
return customInspect(depth, options, 'DecompressionStream', {
150150
readable: this[kTransform].readable,
151151
writable: this[kTransform].writable,
152152
});
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,41 @@
1+
// Flags: --no-warnings --expose-internals
2+
'use strict';
3+
4+
require('../common');
5+
6+
const assert = require('node:assert');
7+
const { describe, it } = require('node:test');
8+
const {
9+
CompressionStream,
10+
DecompressionStream,
11+
} = require('node:stream/web');
12+
13+
const {
14+
customInspectSymbol: kInspect,
15+
} = require('internal/util');
16+
17+
describe('DecompressionStream kInspect method', () => {
18+
it('should return a predictable inspection string with DecompressionStream', () => {
19+
const decompressionStream = new DecompressionStream('deflate');
20+
const depth = 1;
21+
const options = {};
22+
const actual = decompressionStream[kInspect](depth, options);
23+
24+
assert(actual.includes('DecompressionStream'));
25+
assert(actual.includes('ReadableStream'));
26+
assert(actual.includes('WritableStream'));
27+
});
28+
});
29+
30+
describe('CompressionStream kInspect method', () => {
31+
it('should return a predictable inspection string with CompressionStream', () => {
32+
const compressionStream = new CompressionStream('deflate');
33+
const depth = 1;
34+
const options = {};
35+
const actual = compressionStream[kInspect](depth, options);
36+
37+
assert(actual.includes('CompressionStream'));
38+
assert(actual.includes('ReadableStream'));
39+
assert(actual.includes('WritableStream'));
40+
});
41+
});

0 commit comments

Comments
 (0)