Skip to content

Commit 96b9f19

Browse files
committed
f
1 parent b3cc90b commit 96b9f19

File tree

4 files changed

+3
-4
lines changed

4 files changed

+3
-4
lines changed

src/crypto/crypto_aes.cc

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -133,6 +133,8 @@ WebCryptoCipherStatus AES_Cipher(
133133
// Only `ubi81_sharedlibs_openssl111fips_x64` failed when `in.size()` is zero.
134134
// So we regard 0 as special and DO NOT go into `EVP_CipherUpdate()` logic
135135
// because it will occur failure under `ubi81_sharedlibs_openssl111fips_x64`.
136+
//
137+
// Refs: https://github.com/nodejs/node/pull/38913#issuecomment-866505244
136138
if (in.size() == 0) {
137139
out_len = 0;
138140
} else if (!EVP_CipherUpdate(

src/crypto/crypto_cipher.h

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -223,12 +223,11 @@ class CipherJob final : public CryptoJob<CipherTraits> {
223223
*CryptoJob<CipherTraits>::params(),
224224
in_,
225225
&out_);
226-
CryptoErrorStore* errors = CryptoJob<CipherTraits>::errors();
227-
printf("status: %d, errors->Empty(): %d\n", (int)status, (int)errors->Empty());
228226
if (status == WebCryptoCipherStatus::OK) {
229227
// Success!
230228
return;
231229
}
230+
CryptoErrorStore* errors = CryptoJob<CipherTraits>::errors();
232231
errors->Capture();
233232
if (errors->Empty()) {
234233
switch (status) {

src/crypto/crypto_util.cc

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -227,7 +227,6 @@ void CryptoErrorStore::Capture() {
227227
while (const uint32_t err = ERR_get_error()) {
228228
char buf[256];
229229
ERR_error_string_n(err, buf, sizeof(buf));
230-
printf("<<<<<<< %s <<<<<\n", buf);
231230
errors_.emplace_back(buf);
232231
}
233232
std::reverse(std::begin(errors_), std::end(errors_));

test/parallel/test-crypto-subtle-zero-length.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,5 @@ const crypto = require('crypto').webcrypto;
3535
assert(v instanceof ArrayBuffer);
3636
assert.strictEqual(v.byteLength, 0);
3737
})().then(common.mustCall()).catch((e) => {
38-
console.error(e.stack, '<<<');
3938
assert.ifError(e);
4039
});

0 commit comments

Comments
 (0)