Skip to content

Commit 97b2c53

Browse files
authored
test_runner: remove redundant report call
This commit removes a redundant call to `reportStarted()`. It is redundant because a few lines down, `subtest.finalize()` is called. `finalize()` will find the first test that is ready to report its data, and then call `report()`, which also calls `reportStarted()`. This will trigger the `'test:start'` as high up the test tree as necessary. PR-URL: #52089 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Raz Luvaton <[email protected]>
1 parent dafe004 commit 97b2c53

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

lib/internal/test_runner/test.js

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -469,10 +469,6 @@ class Test extends AsyncResource {
469469
return;
470470
}
471471

472-
if (i === 1 && this.parent !== null) {
473-
this.reportStarted();
474-
}
475-
476472
// Report the subtest's results and remove it from the ready map.
477473
subtest.finalize();
478474
this.readySubtests.delete(i);

0 commit comments

Comments
 (0)