Skip to content

Commit 995c3d2

Browse files
committed
doc: test for cli options
1 parent c975384 commit 995c3d2

File tree

3 files changed

+148
-0
lines changed

3 files changed

+148
-0
lines changed

doc/api/cli.md

Lines changed: 35 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2618,11 +2618,15 @@ V8 options that are allowed are:
26182618

26192619
<!-- node-options-v8 end -->
26202620

2621+
<!-- node-options-others start -->
2622+
26212623
`--perf-basic-prof-only-functions`, `--perf-basic-prof`,
26222624
`--perf-prof-unwinding-info`, and `--perf-prof` are only available on Linux.
26232625

26242626
`--enable-etw-stack-walking` is only available on Windows.
26252627

2628+
<!-- node-options-others end -->
2629+
26262630
### `NODE_PATH=path[:…]`
26272631

26282632
<!-- YAML
@@ -2898,6 +2902,24 @@ options are of interest only to V8 developers. Despite this, there is a small
28982902
set of V8 options that are widely applicable to Node.js, and they are
28992903
documented here:
29002904

2905+
<!-- v8-options start -->
2906+
2907+
### `--abort-on-uncaught-exception`
2908+
2909+
### `--disallow-code-generation-from-strings`
2910+
### `--enable-etw-stack-walking`
2911+
### `--harmony-shadow-realm`
2912+
### `--huge-max-old-generation-size`
2913+
### `--jitless`
2914+
2915+
### `--interpreted-frames-native-stack`
2916+
2917+
### `--prof`
2918+
### `--perf-basic-prof`
2919+
### `--perf-basic-prof-only-functions`
2920+
### `--perf-prof`
2921+
### `--perf-prof-unwinding-info`
2922+
29012923
### `--max-old-space-size=SIZE` (in megabytes)
29022924

29032925
Sets the max memory size of V8's old memory section. As memory
@@ -2936,6 +2958,19 @@ for MiB in 16 32 64 128; do
29362958
done
29372959
```
29382960

2961+
### `--security-revert`
2962+
2963+
### `--stack-trace-limit=limit`
2964+
2965+
The maximum number of stack frames to collect in an error's stack trace.
2966+
Setting it to 0 disables stack trace collection. The default value is 10.
2967+
2968+
```bash
2969+
node --stack-trace-limit=12 -p -e "Error.stackTraceLimit" # prints 12
2970+
```
2971+
2972+
<!-- v8-options end -->
2973+
29392974
[#42511]: https://github.com/nodejs/node/issues/42511
29402975
[Chrome DevTools Protocol]: https://chromedevtools.github.io/devtools-protocol/
29412976
[CommonJS]: modules.md

doc/contributing/internal-api.md

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,12 @@ rules. The core developers may remove these flags in any version of Node.js.
88

99
### Flags
1010

11+
#### `--debug-arraybuffer-allocations`
12+
13+
#### `--expose-internals`
14+
15+
Allows to require the `internal/*` modules.
16+
1117
#### `--inspect-brk-node[=[host:]port]`
1218

1319
<!-- YAML
@@ -17,3 +23,11 @@ added: v7.6.0
1723
Activate inspector on `host:port` and break at start of the first internal
1824
JavaScript script executed when the inspector is available.
1925
Default `host:port` is `127.0.0.1:9229`.
26+
27+
#### `--node-snapshot`
28+
29+
#### `--test-udp-no-try-send`
30+
31+
#### `--trace-promises`
32+
33+
#### `--verify-base-objects`
Lines changed: 99 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,99 @@
1+
'use strict';
2+
const common = require('../common');
3+
if (process.config.variables.node_without_node_options)
4+
common.skip('missing NODE_OPTIONS support');
5+
6+
// Test options specified by env variable.
7+
8+
const assert = require('assert');
9+
const fs = require('fs');
10+
const path = require('path');
11+
12+
const rootDir = path.resolve(__dirname, '..', '..');
13+
const cliMd = path.join(rootDir, 'doc', 'api', 'cli.md');
14+
const cliText = fs.readFileSync(cliMd, { encoding: 'utf8' });
15+
16+
const internalApiMd = path.join(rootDir, 'doc', 'contributing', 'internal-api.md');
17+
const internalApiText = fs.readFileSync(internalApiMd, { encoding: 'utf8' });
18+
19+
const nodeOptionsCC = fs.readFileSync(path.resolve(rootDir, 'src', 'node_options.cc'), 'utf8');
20+
const addOptionRE = /AddOption[\s\n\r]*\([\s\n\r]*"([^"]+)"(.*?)\);/gs;
21+
22+
const nodeOptionsText = cliText.match(/<!-- node-options-node start -->(.*)<!-- node-options-others end -->/s)[1];
23+
const v8OptionsText = cliText.match(/<!-- v8-options start -->(.*)<!-- v8-options end -->/s)[1];
24+
25+
// Documented in /doc/api/deprecations.md
26+
const deprecated = [
27+
'--debug',
28+
'--debug-brk',
29+
];
30+
31+
for (const [, envVar, config] of nodeOptionsCC.matchAll(addOptionRE)) {
32+
let hasTrueAsDefaultValue = false;
33+
let isInNodeOption = false;
34+
let isV8Option = false;
35+
let isNoOp = false;
36+
37+
if (config.includes('NoOp{}')) {
38+
isNoOp = true;
39+
}
40+
41+
if (config.includes('kAllowedInEnvvar')) {
42+
isInNodeOption = true;
43+
}
44+
if (config.includes('kDisallowedInEnvvar')) {
45+
isInNodeOption = false;
46+
}
47+
48+
if (config.includes('V8Option{}')) {
49+
isV8Option = true;
50+
}
51+
52+
if (/^\s*true\s*$/.test(config.split(',').pop())) {
53+
hasTrueAsDefaultValue = true;
54+
}
55+
56+
if (
57+
envVar.startsWith('[') ||
58+
deprecated.includes(envVar) ||
59+
isNoOp
60+
) {
61+
continue;
62+
}
63+
64+
// Internal API options are documented in /doc/contributing/internal-api.md
65+
if (new RegExp(`####.*\`${envVar}[\[=\\s\\b\`]`).test(internalApiText) === true) {
66+
continue;
67+
}
68+
69+
// CLI options
70+
if (!isV8Option && !hasTrueAsDefaultValue && new RegExp(`###.*\`${envVar}[\[=\\s\\b\`]`).test(cliText) === false) {
71+
assert(false, `Should have option ${envVar} documented`);
72+
}
73+
74+
if (!hasTrueAsDefaultValue && new RegExp(`###.*\`--no-${envVar.slice(2)}[\[=\\s\\b\`]`).test(cliText) === true) {
75+
assert(false, `Should not have option --no-${envVar.slice(2)} documented`);
76+
}
77+
78+
if (!isV8Option && hasTrueAsDefaultValue && new RegExp(`###.*\`--no-${envVar.slice(2)}[\[=\\s\\b\`]`).test(cliText) === false) {
79+
assert(false, `Should have option --no-${envVar.slice(2)} documented`);
80+
}
81+
82+
// NODE_OPTIONS
83+
if (isInNodeOption && !hasTrueAsDefaultValue && new RegExp(`\`${envVar}\``).test(nodeOptionsText) === false) {
84+
assert(false, `Should have option ${envVar} in NODE_OPTIONS documented`);
85+
}
86+
87+
if (isInNodeOption && hasTrueAsDefaultValue && new RegExp(`\`--no-${envVar.slice(2)}`).test(cliText) === false) {
88+
assert(false, `Should have option --no-${envVar.slice(2)} in NODE_OPTIONS documented`);
89+
}
90+
91+
if (!hasTrueAsDefaultValue && new RegExp(`\`--no-${envVar.slice(2)}`).test(cliText) === true) {
92+
assert(false, `Should not have option --no-${envVar.slice(2)} in NODE_OPTIONS documented`);
93+
}
94+
95+
// V8 options
96+
if (isV8Option && new RegExp(`###.*\`${envVar}[\[=\\s\\b\`]`).test(v8OptionsText) === false) {
97+
assert(false, `Should have option ${envVar} in V8 options documented`);
98+
}
99+
}

0 commit comments

Comments
 (0)